Skip to content

Doc updates for 12.8 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 24, 2025
Merged

Doc updates for 12.8 #366

merged 8 commits into from
Jan 24, 2025

Conversation

vzhurba01
Copy link
Collaborator

@vzhurba01 vzhurba01 commented Jan 8, 2025 •
edited by leofang
Loading

@vzhurba01 vzhurba01 added documentation Improvements or additions to documentation cuda.bindings Everything related to the cuda.bindings module labels Jan 8, 2025
@vzhurba01 vzhurba01 added this to the cuda-python 12-next, 11-next milestone Jan 8, 2025
@vzhurba01 vzhurba01 self-assigned this Jan 8, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01 vzhurba01 mentioned this pull request Jan 8, 2025
Merged
@leofang
Copy link
Member

leofang commented Jan 9, 2025

Q: is this still a draft?

@leofang
Copy link
Member

leofang commented Jan 9, 2025

We will need to add a release note for 11.8.6 too, to cover #369.

@vzhurba01
Copy link
Collaborator Author

I'm considering keeping this as a draft until all documentation issues are complete. Perhaps having this PR instead act as a collection of 12-next exclusive documentation updates that can't be merged until release. Right now it's just the optional dependencies, but there might be more after I go through some of my current documentation tasks.

@leofang leofang mentioned this pull request Jan 10, 2025
Merged
@vzhurba01 vzhurba01 marked this pull request as draft January 10, 2025 19:41
@vzhurba01 vzhurba01 changed the title Draft: Add PYPI optional dependencies installation instructions Add PYPI optional dependencies installation instructions Jan 10, 2025
@vzhurba01
Copy link
Collaborator Author

TODO: Apply #372 (comment) to this PR talking about [all] and update PR to represent the post-release documentation changes.

@leofang leofang self-assigned this Jan 24, 2025
@leofang leofang changed the title Add PYPI optional dependencies installation instructions Doc updates for 12.8 Jan 24, 2025
@leofang leofang mentioned this pull request Jan 24, 2025
Closed
@leofang
Copy link
Member

leofang commented Jan 24, 2025

/ok to test

@leofang leofang mentioned this pull request Jan 24, 2025
Merged
@leofang leofang marked this pull request as ready for review January 24, 2025 18:24
@leofang
Copy link
Member

leofang commented Jan 24, 2025

/ok to test

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang
3 fixes
44f3c3e 
- fix support page rendering
- fix relative url
- add 11.8.6 cuda-python nodes
@leofang leofang requested a review from ksimpson-work January 24, 2025 19:41
@leofang leofang requested a review from rwgk January 24, 2025 19:41
leofang
leofang reviewed Jan 24, 2025
View reviewed changes
rwgk
rwgk approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I didn't do local testing.

@leofang
Copy link
Member

leofang commented Jan 24, 2025

admin-merge to trigger a build in the main branch

@leofang leofang merged commit c04025d into NVIDIA:main Jan 24, 2025
1 check passed
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

@rwgk rwgk rwgk approved these changes

@ksimpson-work ksimpson-work ksimpson-work approved these changes

Assignees

@leofang leofang

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.

Document the expectation of Python object lifetime for binding users Document support policies
4 participants
@vzhurba01 @leofang @rwgk @ksimpson-work