Skip to content

Add bandit config, fix failing issues #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

kkraus14
Copy link
Collaborator

Description

When #560 added Bandit, it didn't fix the existing issues in the codebase that Bandit flags. This fixes the issues and skips them where the fixes are non-trivial and the underlying issue is relatively innocuous.

Additionally, adds a .bandit configuration file to the root of the repo that bandit will use by default and tells pre-commit to use that configuration file as well.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Apr 24, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kkraus14
Copy link
Collaborator Author

/ok to test

This comment has been minimized.

@kkraus14
Copy link
Collaborator Author

/ok to test

@leofang leofang added enhancement Any code-related improvements CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels Apr 25, 2025
@leofang leofang added this to the cuda-python 12.9.0 & 11.8.7 milestone Apr 25, 2025
@leofang leofang merged commit 161306b into NVIDIA:main Apr 25, 2025
78 checks passed
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants