-
Notifications
You must be signed in to change notification settings - Fork 171
Always build and run Cython tests + other CI improvements #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c41a39a
try to also build cuda.bindings Cython tests at the build stage
leofang 227e315
we can no longer lock host Python version
leofang 2b38518
check if this hack from the test workflow also fixes cibuildwheel
leofang 9fc20e1
also install test deps
leofang 512e613
AGENT_TOOLSDIRECTORY needs to be writable
leofang de4db55
test
leofang be78f1b
test
leofang a0f964d
test
leofang 19e5709
ensure AGENT_TOOLSDIRECTORY is persistent
leofang 78c8afd
do this instead
leofang c626592
fixes
leofang dd86fe4
fix windows
leofang a13f0ef
fix
leofang 4af05da
fix dir
leofang 8592024
extra dot
leofang 27418ef
ensure the Python include path is visible
leofang 254748b
fix python include path; only install essential build deps; add tests
leofang ba0711b
fix escape; revert test dep installation handling
leofang 0397b88
misc fixes
leofang 3c3899c
fix win artifact location; pin action commits; enable cuda.core cytho…
leofang 0a9ae25
revert pinning ilammy/msvc-dev-cmd for now
leofang a524b8c
set up a simple dependabot
leofang 3554334
fix spdx identifier
leofang 8f7a054
add cuda.core include path
leofang 9ad27ac
try this
leofang 08c5579
again
leofang f589987
ensure cython tests are only run when testing against build CTK
leofang 452fced
try to avoid Cython 3.1 to speed up build time
leofang 15ac320
pin exact commit for all non-NV GHA
leofang d6ada33
move some reusable logics into build_tests.sh
leofang f5ffde9
fix path format, again
leofang f409d19
try enforcing double slashes
leofang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ runs: | |
# Note: the PR previews will be removed once merged to main (see below) | ||
- name: Deploy doc preview | ||
if: ${{ github.ref_name != 'main' }} | ||
uses: JamesIves/github-pages-deploy-action@v4 | ||
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3 | ||
with: | ||
git-config-name: cuda-python-bot | ||
git-config-email: [email protected] | ||
|
@@ -31,7 +31,7 @@ runs: | |
|
||
- name: Leave a comment after deployment | ||
if: ${{ github.ref_name != 'main' }} | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
uses: marocchino/sticky-pull-request-comment@67d0dec7b07ed060a405f9b2a64b8ab319fdd7db # v2.9.2 | ||
with: | ||
header: pr-preview | ||
number: ${{ inputs.pr-number }} | ||
|
@@ -47,7 +47,7 @@ runs: | |
# The steps below are executed only when building on main. | ||
- name: Remove doc preview | ||
if: ${{ github.ref_name == 'main' }} | ||
uses: JamesIves/github-pages-deploy-action@v4 | ||
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3 | ||
with: | ||
git-config-name: cuda-python-bot | ||
git-config-email: [email protected] | ||
|
@@ -57,7 +57,7 @@ runs: | |
|
||
- name: Leave a comment after removal | ||
if: ${{ github.ref_name == 'main' }} | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
uses: marocchino/sticky-pull-request-comment@67d0dec7b07ed060a405f9b2a64b8ab319fdd7db # v2.9.2 | ||
with: | ||
header: pr-preview | ||
number: ${{ inputs.pr-number }} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. ALL RIGHTS RESERVED. | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: github-actions | ||
directory: / | ||
schedule: | ||
interval: weekly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ jobs: | |
shell: bash -el {0} | ||
steps: | ||
- name: Checkout ${{ github.event.repository.name }} | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
with: | ||
fetch-depth: 0 | ||
ref: ${{ inputs.git-tag }} | ||
|
@@ -56,7 +56,7 @@ jobs: | |
# is resolved | ||
|
||
- name: Set up miniforge | ||
uses: conda-incubator/setup-miniconda@v3 | ||
uses: conda-incubator/setup-miniconda@505e6394dae86d6a5c7fbb6e3fb8938e3e863830 # v3.1.1 | ||
with: | ||
activate-environment: cuda-python-docs | ||
environment-file: ./cuda_python/docs/environment-docs.yml | ||
|
@@ -103,7 +103,7 @@ jobs: | |
echo "CUDA_BINDINGS_ARTIFACTS_DIR=$(realpath "$REPO_DIR/cuda_bindings/dist")" >> $GITHUB_ENV | ||
|
||
- name: Download cuda-python build artifacts | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
with: | ||
name: cuda-python-wheel | ||
path: . | ||
|
@@ -117,14 +117,14 @@ jobs: | |
|
||
- name: Download cuda.bindings build artifacts | ||
if: ${{ !inputs.is-release }} | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
with: | ||
name: ${{ env.CUDA_BINDINGS_ARTIFACT_NAME }} | ||
path: ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }} | ||
|
||
- name: Download cuda.bindings build artifacts | ||
if: ${{ inputs.is-release }} | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
with: | ||
pattern: ${{ env.CUDA_BINDINGS_ARTIFACT_NAME }} | ||
merge-multiple: true | ||
|
@@ -139,14 +139,14 @@ jobs: | |
|
||
- name: Download cuda.core build artifacts | ||
if: ${{ !inputs.is-release }} | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
with: | ||
name: ${{ env.CUDA_CORE_ARTIFACT_NAME }} | ||
path: ${{ env.CUDA_CORE_ARTIFACTS_DIR }} | ||
|
||
- name: Download cuda.core build artifacts | ||
if: ${{ inputs.is-release }} | ||
uses: actions/download-artifact@v4 | ||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
with: | ||
pattern: ${{ env.CUDA_CORE_ARTIFACT_NAME }} | ||
merge-multiple: true | ||
|
@@ -221,7 +221,7 @@ jobs: | |
|
||
# TODO: Consider removing this step? | ||
- name: Upload doc artifacts | ||
uses: actions/upload-pages-artifact@v3 | ||
uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3.0.1 | ||
with: | ||
path: artifacts/ | ||
retention-days: 3 | ||
|
@@ -236,7 +236,7 @@ jobs: | |
|
||
- name: Deploy doc update | ||
if: ${{ github.ref_name == 'main' || inputs.is-release }} | ||
uses: JamesIves/github-pages-deploy-action@v4 | ||
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3 | ||
with: | ||
git-config-name: cuda-python-bot | ||
git-config-email: [email protected] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have these built by a more standard mechanism and avoid needing to run a separate bash script. Any reason we wouldn't want these built when invoking
pip install
?Doesn't need to be solved in this PR regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought, I have some local changes (started on build) I will rebase once this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I don't want to include the built tests in the wheel. If there is a way to achieve this with the build frontend/backend, it'd certainly simplify
build-wheel.yml
here, but I couldn't find any.