SPDX-FileCopyrightText cleanup
#753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom check-spdx hook with espressif/check-copyright v1.1.1 - Add .check-copyright-config.yaml with comprehensive configuration - Support both Apache-2.0 and LicenseRef-NVIDIA-SOFTWARE-LICENSE - Configure ignore patterns matching original .spdx-ignore - Separate rules for different file types and project components
…dation" This reverts commit 03e2d89. This didn't work out. Leaving this for "maybe later".
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kkraus14
approved these changes
Jul 11, 2025
Comment on lines
+1
to
3
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE |
There was a problem hiding this comment.
Not a blocker, but in some files there is an empty line between these and other files don't have the empty line. It would be nice to make it consistent and probably amenable to cursor fixing it.
There was a problem hiding this comment.
Thanks! I'll merge this and fix the empty lines separately.
|
leofang
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #635
This was done with Cursor.
I tried to switch to the espressif/check-copyright tool (commit 03e2d89) but ran into problems (and out of time). That switch is better left for a separate PR.