Repository navigation
Preserve spatial coordinates for single-pixel FSS windows - #1227
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Contributor
|
Disclaimer: This is AI-generated, please review response for accuracy
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
Closes #1226.
Use an open-ended coordinate slice when the trailing FSS window margin is zero. Single-pixel windows previously turned both spatial coordinates into empty arrays and failed during reduction. The corrected result matches the pointwise deterministic/probabilistic FSS definition; cropping for larger odd/even windows is unchanged.
Validation
python -m pytest -q -o addopts='' test/statistics/test_fss.py test/statistics/test_fss_single_pixel.py -k 'not cuda'14 passed, 6 CUDA cases deselected. Eight new cases cover float32/float64 pointwise scores, a custom ensemble dimension, reordered spatial axes, streaming updates, and coordinate extents for window sizes 1/2/3. Six new cases fail on unchanged upstream and two controls pass.
All changed-file pre-commit hooks pass, including Black, Ruff, mypy, docstring coverage and Markdown checks. Tested on CPU; no pretrained-model or network-data inference was needed. CUDA and the full repository suite were not run.
Checklist
Dependencies
No new dependencies.