Skip to content

Preserve spatial coordinates for single-pixel FSS windows - #1227

Open
sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:mainfrom
sylvesterkaczmarek:fix/fss-single-pixel-window-20261005
Open

sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:mainfrom
sylvesterkaczmarek:fix/fss-single-pixel-window-20261005

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Earth2Studio Pull Request

Description

Closes #1226.

Use an open-ended coordinate slice when the trailing FSS window margin is zero. Single-pixel windows previously turned both spatial coordinates into empty arrays and failed during reduction. The corrected result matches the pointwise deterministic/probabilistic FSS definition; cropping for larger odd/even windows is unchanged.

Validation

python -m pytest -q -o addopts='' test/statistics/test_fss.py test/statistics/test_fss_single_pixel.py -k 'not cuda'

14 passed, 6 CUDA cases deselected. Eight new cases cover float32/float64 pointwise scores, a custom ensemble dimension, reordered spatial axes, streaming updates, and coordinate extents for window sizes 1/2/3. Six new cases fail on unchanged upstream and two controls pass.

All changed-file pre-commit hooks pass, including Black, Ruff, mypy, docstring coverage and Markdown checks. Tested on CPU; no pretrained-model or network-data inference was needed. CUDA and the full repository suite were not run.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • Documentation remains consistent with the existing FSS API.
  • CHANGELOG.md is updated.
  • An issue is linked to this pull request.
  • Assess and address review feedback when available.

Dependencies

No new dependencies.

Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Disclaimer: This is AI-generated, please review response for accuracy

RetriggerConfidence Score: 5/5

[Medium risk] Fixes spatial coordinate handling in a statistics calculation.

The PR appears safe to merge; no actionable regression was found.

Summary

The PR preserves spatial coordinates for one-pixel FSS windows, adds pointwise and coordinate-extent tests, and documents the fix in the changelog.

Reviews (1) · Last reviewed commit: "Preserve spatial coordinates for single-..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single-pixel FSS windows produce empty coordinates and fail scoring

1 participant