fix(device): only trim PCI bus ID prefix for padded 8-digit domains#89
Merged
Conversation
This helps when testing with nvml-mock library which returns busID of the form 0000:D8:00.0 instead of typical padded busID like 00000000:D8:00.0 from NVML. Without the fix, GetPCIBusID() returns an invalid busID as :0a:00.0. The change that triggered this behavior was NVIDIA/k8s-test-infra#353 Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps when testing with nvml-mock library which returns busID of the form
0000:D8:00.0instead of typical padded busID like00000000:D8:00.0from NVML. Without the fix, GetPCIBusID() returns an invalid busID as:0a:00.0The change that triggered this behavior was NVIDIA/k8s-test-infra#353