Skip to content

[Bug]: Uncordon already cordoned nodes #212

Description

@just1not2

Describe the bug
During the uninstall process, the driver manager cordons the node and it uncordons it at the very end of the process.
If the node is already cordoned at the beginning of this process, the driver manager should not uncordon it at the end. Cordons are used by Kubernetes administrators and Operators for various reasons and it should not be mandatory to remove the cordons at the end of this process (at least there should be a flag to opt out).

To Reproduce

  • cordon a node
  • launch the driver manager on it
  • verify that the node in uncordoned

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please provide the following information):

  • k8s-driver-manager source (Commit SHA or image digest): main
  • Host OS: all
  • Kernel Version: all
  • NVIDIA Driver Version: all
  • Container Runtime Version: all
  • CPU Architecture: all
  • GPU Model(s): all

If applicable, also provide:

  • Kubernetes Distro and Version: all
  • NVIDIA GPU Operator version: all

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue/PR to expose/discuss/fix a bugneeds-triageissue or PR has not been assigned a priority-px label

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions