Integrated Branch for FP8 Bindgen #247
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added a commit
that referenced
this pull request
Dec 2, 2025
This is a sub-issue from #247 . Previously we have prefix removal feature for standalone functions. This PR expands the feature to Struct and Enums. Assuming a prefix named `_prefix_` is to be removed, a struct named `_prefix_Foo` is named `Foo` in python. A enum defined below: ```c++ enum _prefix_Fruit { _prefix_Apple, _prefix_Banana }; ``` will be exported as: ```Python Fruit(IntEnum): Apple = 0 Banana = 1 ``` in python. This is to say that the prefix removal is applicable to both enum name as well as the members. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Configurable prefix removal for enums, structs, and functions so exported Python names omit configured prefixes. * Enum symbol list is now exposed in module exports for easier discovery. * **Refactor** * Centralized prefix-removal and unified Python-facing name handling across binding generation and symbol registration. * Rendering internals now propagate Python-visible names consistently. * **Tests** * Added/updated tests to verify prefix removal and symbol exposure; tests invoke kernels directly and reset renderer/function caches. * **Documentation** * Clarified enum registration docstring. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Michael Wang <[email protected]>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an integrated improvement branch that implements gaps needed for Numba-CUDA FP8 Binding Generation. I'll cherry-pick out the individual features and submit them in separate PRs.