Ignore dyn.shim.excluded.releases when shimplifying

[razajafri]

This PR ignores the dyn.shim.excluded.releases when generating shims otherwise, shims don't get generated for files whose root directory is in the shim that is excluded.

fixes #12806

[razajafri]

build

[gerashegalov]

It is hard to follow why this callsite is supposed to be isShimplify=True. Should it rather refer to what this flag is affecting such as ignore_excluded_shims=True or honor_excluded_shims=False with a comment what the difference is.

[razajafri]

I guess to me it was clear because if we are calling this from simplify then we don't care about the excluded shims in pom.

I can rename it if it will make it more clear

[gerashegalov]

Since this PR is resolving the scenario in #12806 of adding a shim, why is it not restricted to -Dshimplify=true or add/remove?

[razajafri]

Since this PR is resolving the scenario in #12806 of adding a shim, why is it not restricted to -Dshimplify=true or add/remove?

That will produce bad output when running shimplify=false and shimplify.trace i.e. the user will not see the excluded shim as being generated but when he actually runs it, it will modify that directory.

[gerashegalov]

That will produce bad output when running shimplify=false and shimplify.trace i.e. the user will not see the excluded shim as being generated but when he actually runs it, it will modify that directory.

I am still confused based on the description in #12806 : Is this fix necessary if you don't add or remove shims ?

[razajafri]

That will produce bad output when running shimplify=false and shimplify.trace i.e. the user will not see the excluded shim as being generated but when he actually runs it, it will modify that directory.

I am still confused based on the description in #12806 : Is this fix necessary if you don't add or remove shims ?

That will produce bad output when running shimplify=false and shimplify.trace i.e. the user will not see the excluded shim as being generated but when he actually runs it, it will modify that directory.

I am still confused based on the description in #12806 : Is this fix necessary if you don't add or remove shims ?

I have updated the description PTAL.

Yes, this change is necessary IMO even when just running shimplify=false with trace on.