Skip to content

Remove cluster connection override #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Namoshek merged 2 commits into from
Nov 6, 2024
Merged

Remove cluster connection override #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d777294
Remove cluster connection override to use default cluster connector f…
Nov 6, 2024
30103af
Remove obsolete NotImplementedException
Namoshek Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Connectors/PhpRedisSentinelConnector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
use Illuminate\Support\Arr;
use Namoshek\Redis\Sentinel\Connections\PhpRedisSentinelConnection;
use Namoshek\Redis\Sentinel\Exceptions\ConfigurationException;
use Namoshek\Redis\Sentinel\Exceptions\NotImplementedException;
use Redis;
use RedisException;
use RedisSentinel;
Expand Down Expand Up @@ -36,14 +35,6 @@ public function connect(array $config, array $options): PhpRedisSentinelConnecti
return new PhpRedisSentinelConnection($connector(), $connector, $config);
}

/**
* {@inheritdoc}
*/
public function connectToCluster(array $config, array $clusterOptions, array $options)
{
throw new NotImplementedException('The Redis Sentinel driver does not support connecting to clusters.');
}

/**
* Create the PhpRedis client instance which connects to Redis Sentinel.
*
Expand Down
12 changes: 0 additions & 12 deletions src/Exceptions/NotImplementedException.php
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions tests/Connectors/PhpRedisSentinelConnectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use Illuminate\Redis\RedisManager;
use Namoshek\Redis\Sentinel\Connections\PhpRedisSentinelConnection;
use Namoshek\Redis\Sentinel\Connectors\PhpRedisSentinelConnector;
use Namoshek\Redis\Sentinel\Exceptions\NotImplementedException;
use Namoshek\Redis\Sentinel\Tests\TestCase;
use Redis;
use RedisException;
Expand All @@ -17,18 +16,6 @@
*/
class PhpRedisSentinelConnectorTest extends TestCase
{
public function test_connecting_to_cluster_is_not_possible()
{
$this->expectException(NotImplementedException::class);

$connector = new PhpRedisSentinelConnector();
$connector->connectToCluster(
config: [],
clusterOptions: [],
options: []
);
}

/**
* @throws RedisException
*/
Expand Down