Skip to content

Console.log in worker makes chrome debugging crash #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoeyBG opened this issue Oct 3, 2019 · 0 comments
Closed

Console.log in worker makes chrome debugging crash #1511

JoeyBG opened this issue Oct 3, 2019 · 0 comments
Assignees
@darind
Milestone
6.2.0

Comments

@JoeyBG
Copy link

JoeyBG commented Oct 3, 2019

I was investigating why we suddenly couldn't debug our app, and I realized it was due to a stray console.log in a worker.

Steps: To reproduce

  1. Run the sample in debug using tns debug android
  2. Open Chrome dev-tools
  3. Reload the app so that your chrome is connected before the worker is called (or just add a button to re-send a message...)
  4. Application crashes like this:
    image

This obviously work if you remove the console.log, or if you do not debug.

This also prevents VSCode debugging, same behavior.
@rosen-vladimirov rosen-vladimirov transferred this issue from NativeScript/worker-loader Oct 14, 2019
darind added a commit that referenced this issue Oct 14, 2019
@darind
fix: console.log in worker should not crash app (#1511)
5dd2c9a
@darind darind mentioned this issue Oct 14, 2019
Merged
darind added a commit that referenced this issue Oct 14, 2019
@darind
Merge pull request #1513 from NativeScript/darind/inspector-worker-co…
2b992cb 
…nsole

fix: console.log in worker should not crash app (#1511)
@darind darind self-assigned this Oct 14, 2019
@darind darind added this to the 6.2.0 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darind darind

Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
4 participants
@darind @miroslavaivanova @JoeyBG @vhristov5555