Skip to content

Refactor build.gradle not to add configuration:'default' #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

vtrifonov
Copy link
Contributor

@vtrifonov vtrifonov commented Mar 14, 2019

Related to #1309

Seems like using:

implementation project(path: ':runtime', configuration: 'default')

is not the right solution as stated here
The only place that doesn't work without the configuration: 'default' is the config.resolve() which is used to get the dependencies, but by getting them through the config.incoming.artifactView we even can get only the .jar files, but not .aar as they are already unarchived in the gradle cache and the .jar files are in the artifactView list already.

@cla-bot cla-bot bot added the cla: yes label Mar 14, 2019
@darind darind self-requested a review March 14, 2019 17:51
@vtrifonov vtrifonov merged commit 102edea into master Mar 14, 2019
@vtrifonov vtrifonov deleted the trifonov/gradle-build-improvements branch March 18, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants