Skip to content

chore: remove min/target SdkVersion from manifest #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

vtrifonov
Copy link
Contributor

@vtrifonov vtrifonov commented Mar 15, 2019

Related to #1316

We don't need minSdkVersion and targetSdkVersion in the manifest file and it even gives errors when you open a nativescript app in android studio

run sbg tests and android tests with one command
@cla-bot cla-bot bot added the cla: yes label Mar 15, 2019
@darind darind self-requested a review March 16, 2019 11:05
@vtrifonov vtrifonov merged commit bce8394 into master Mar 18, 2019
@vtrifonov vtrifonov deleted the trifonov/manifest-remove-not-needed branch March 18, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants