-
-
Notifications
You must be signed in to change notification settings - Fork 136
Refactor static binding generator #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test |
9630fad
to
b3367b7
Compare
test |
70920fd
to
c425d3d
Compare
c425d3d
to
5592b23
Compare
test |
test ngapps tsapps tscapps jsapps --ignore api23 api28 |
vtrifonov
suggested changes
Mar 19, 2019
...tatic-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/Generator.java
Outdated
Show resolved
Hide resolved
...ivescript/staticbindinggenerator/generating/parsing/methods/impl/MethodSignatureReifier.java
Outdated
Show resolved
Hide resolved
.../java/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java
Outdated
Show resolved
Hide resolved
.../java/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java
Outdated
Show resolved
Hide resolved
.../java/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java
Outdated
Show resolved
Hide resolved
...ating/parsing/classes/hierarchy/generics/impl/GenericsAwareClassHierarchyParserImplTest.java
Outdated
Show resolved
Hide resolved
5592b23
to
87b5a51
Compare
vtrifonov
approved these changes
Mar 19, 2019
4e9f3e5
to
1e018af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1322, #689