Skip to content

Fix creation of URLClassLoader #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

vmutafov
Copy link
Contributor

With the current URLClassLoader initialisation, it has the system class loader as a parent. Due to the implementation of the Java class loaders, when loadClass() is invoked, it calls the parent loadClass() method first. So, in our case, when loading up a class coming from a jar file, it is resolved first by the system class loader and if it can't resolve it - uses the URLClassLoader. This is not a problem in most cases, however when parsing classes coming from a jar file which can also be found in the SBG dependencies, class versioning problems may occur.

@cla-bot cla-bot bot added the cla: yes label Mar 31, 2019
@vmutafov
Copy link
Contributor Author

#1329

@vmutafov
Copy link
Contributor Author

test ngapps tsapps tscapps jsapps

@vmutafov vmutafov merged commit e031ff1 into master Apr 1, 2019
@vmutafov vmutafov deleted the vmutafov/urlclassloader-fix branch April 1, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants