Add super.onCreate() call in generated onCreate method #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtrifonov
approved these changes
Jul 18, 2019
|
@vtrifonov linked to the origin issue in the webpack repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: NativeScript/nativescript-dev-webpack#952
Related to: #1426
Currently, if the user hasn't provided an
onCreatemethod implementation, the SBG generates theonCreatemethod for object initialization. This auto-generated method, however, doesn't have a call to the parent class' method and in some cases like extending anIntentServicean exception occurs when Android creates an instance of the service. This commit adds a call tosuper.onCreate()