set "stack" property of error to js stack trace #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmutafov
reviewed
Oct 11, 2019
| @@ -285,9 +293,10 @@ public static String getStackTraceErrorMessage(Throwable ex) { | |||
|
|
|||
| try { | |||
| content = baos.toString("US-ASCII"); | |||
vmutafov
approved these changes
Oct 11, 2019
vtrifonov
force-pushed
the
trifonov/setting-error-stack
branch
from
7543d81 to
9b4ebf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1445
Set the thrown javascript exception's "stack" property to the JS only stack trace as this is a JS error and works in the same way in iOS. The full stack trace (JS + Native) can be found in the "stackTrace" property