Plamen5kov/update project template #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move xml files remove unused dependency from test-app
remove unnecessary folder from build tools
updated gradle to 4.1 updated settings.gradle updated gradle.properties
|
💔 |
|
💔 |
|
@Plamen5kov Why don't we try to update to Gradle 4.3 and Android Plugin 3.0.0 for improved build speeds? Edit: never mind, just noticed the changes to the automatic variants matching - https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#variant_aware which we most likely break by the improper use of flavors we have for handling nativescript plugins. |
|
@Pip3r4o once we make the integration with Android Studio, the update from version to version should become automatic. Android Studio should prompt for gradle update once a newer version is installed. |
|
💔 |
petekanev
approved these changes
Nov 6, 2017
|
💔 |
|
💔 |
|
run ci |
|
💚 |
dtopuzov
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before it's tested with functional tests. Needs QA approval before a merge.
<app_name>platforms/androidproject in Android Studio (>=2.3.3))related issue: #876
related PR: NativeScript/nativescript-dev-webpack#310
NativeScript/nativescript-cli#3193