-
-
Notifications
You must be signed in to change notification settings - Fork 59
VSCode debugger crashes on old simulators #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
mbektchiev
added a commit
that referenced
this issue
Feb 25, 2019
* Add `isImplementedInClass` and `isAvailableInClass` methods in `PropertyMeta` and `MethodMeta` which additionally check whether a Class instance supports a given optional method * Use `isAvailableInClass` instead of `isAvailable` in `getOwnPropertySlot` of `ObjCPrototype`, `ObjCConstructorBase`, `ObjCConstructorNative` * Add `findInterfaceMeta` function with fallback to base interface if the desired one is unavailable in the current SDK version * Add `encodeVersion` `getMajorVersion` and `getMinorVersion` helpers * Remove hacky patch from `ObjCMethodWrapper::preInvocation` which fixed the symptoms of #978 but not its root cause * Modify fixtures and add test cases for methods availability in `InheritanceTests.js` * Add test case for unavailable base class refs #1084
mbektchiev
added a commit
that referenced
this issue
Feb 25, 2019
* Respect availability attribute in protocols * Fix typo Protcols -> Protocols * Add tests refs #1084
The bug is caused by |
5 tasks
mbektchiev
added a commit
that referenced
this issue
Feb 25, 2019
* Respect availability attribute in protocols * Fix typo Protcols -> Protocols * Add tests refs #1084
mbektchiev
added a commit
that referenced
this issue
Feb 27, 2019
* Respect availability attribute in protocols * Add tests refs #1084
mbektchiev
added a commit
that referenced
this issue
Feb 27, 2019
* Respect availability attribute in protocols * Add tests refs #1084
mbektchiev
added a commit
that referenced
this issue
Feb 28, 2019
Apple regularly create new protocols and move existing interface members there. E.g. iOS 12.0 introduced the UIFocusItemScrollableContainer protocol in UIKit which contained members that have existed in UIScrollView since iOS 2.0. * Create `findProtocol` function in `GlobalTable` * Use it instead of `findMeta` everwhere where a protocol is looked for * Add tests refs #1084
mbektchiev
added a commit
that referenced
this issue
Feb 28, 2019
Apple regularly create new protocols and move existing interface members there. E.g. iOS 12.0 introduced the UIFocusItemScrollableContainer protocol in UIKit which contained members that have existed in UIScrollView since iOS 2.0. * Create `findProtocol` function in `GlobalTable` * Use it instead of `findMeta` everwhere where a protocol is looked for * Add tests refs #1084
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Describe the bug
To Reproduce
tns create jsApp --js && cd jsApp && code .
onTap
method with the one below:Launch on iOS
from VSCode.nativeView
of the button.[UIButton adjustsImageSizeForAccessibilityContentSizeCategory]: unrecognized selector sent to instance
exception and the app will crash (this property is introduced in iOS 11).Expected behavior
The iOS runtime should not return properties for newer iOS version through the debug protocol. In this case the returned properties should be for iOS <=9.3.
The text was updated successfully, but these errors were encountered: