fix: fix waitForDebugger handling #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the 5.1.1 releases of the CLI and the Runtime, the CLI is always sending `AttachRequest` before a debug session which is clearing the `listenSource`. In this way, the app is resumed and the `--debug-brk` flag is not working properly. In order to avoid that, we do not resume the app when closing the listening source anymore. It will be resumed only when a debugging client is attached or the 30 secs timeout is reached.
rosen-vladimirov
approved these changes
Feb 6, 2019
mbektchiev
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
After the 5.1.1 releases of the CLI and the Runtime, the CLI is always sending
AttachRequestbefore a debug session which is clearing thelistenSource. In this way, the app is resumed and the--debug-brkflag is not working properly.What is the new behavior?
In order to avoid that, we do not resume the app when closing the listening source anymore. It will be resumed only when a debugging client is attached or when the 30 secs timeout is reached.