Skip to content

added missing webpack config file #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

henrytongv
Copy link

PR Checklist

What is the current behavior?

The example project does not work when trying to execute"ns run android". It fails with the error message "missing file webpack.config.js"

What is the new behavior?

I added the missing file. This is useful for people new to NativeScript (like me) because with this fix the project will run as-is out of the box and we can get started quickly using NativeScript

Fixes/Implements/Closes #[Issue Number].

I do not see any breaking changes

BREAKING CHANGES:

I do not see any breaking changes

Migration steps:
[Provide a migration path for existing applications.]
-->

By the way this link does not exist: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md

@cla-bot cla-bot bot added the cla: yes label Apr 10, 2023
@henrytongv
Copy link
Author

Also, the back button that appears in the detail list is missing a label. I added one.

This fix helps accessibility of the app and allows people that use a screen reader to quickly test an example app done with NativeScript

@vallemar
Copy link

@rigor789 I think this is a problem of the new version of the cli. I have had this same problem right now after updating nativescript

@rigor789
Copy link
Member

Will look into it soon, noticed something changed but couldn't take a look before my trip.

rigor789 added a commit to NativeScript/nativescript-cli that referenced this pull request Apr 12, 2023
rigor789 added a commit to NativeScript/nativescript-cli that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants