Skip to content

Commit d770a2b

Browse files
Romulo PiresVladimir Amiorkov
Romulo Pires
authored and
Vladimir Amiorkov
committed
fix(android-upload): Fix some params vars to be a string (#252)
* fix(android-upload): Fix some params vars to be a string Convert param to string before send to Java method Referenced in #249 * fix(android-upload): Remove missing lock files Removed missing lock files that i forget in before commit Referenced in issue 249
1 parent a626753 commit d770a2b

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

demo-angular/app/home/home.component.ts

+2
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ export class HomeComponent {
6868
if (isMulti) {
6969
const params = [
7070
{ name: "test", value: "value" },
71+
{ name: "testInt", value: 10 },
72+
{ name: "bool", value: true },
7173
{ name: "fileToUpload", filename: this.file, mimeType: 'image/jpeg' }
7274
];
7375
task = this.session.multipartUpload(params, request);

src/background-http.android.ts

+10-9
Original file line numberDiff line numberDiff line change
@@ -278,17 +278,18 @@ function getMultipartRequest(taskId: string, options: common.Request, params: an
278278
if (typeof curParam.name === 'undefined') {
279279
throw new Error("You must have a `name` value");
280280
}
281-
if (curParam.filename) {
282-
let fileName = curParam.filename;
283-
if (fileName.startsWith("~/")) {
284-
fileName = fileName.replace("~/", fileSystemModule.knownFolders.currentApp().path + "/");
285-
}
286-
const destFileName = curParam.destFilename || fileName.substring(fileName.lastIndexOf('/') + 1, fileName.length);
287-
request.addFileToUpload(fileName, curParam.name, destFileName, curParam.mimeType);
281+
282+
if (typeof curParam.filename === 'undefined') {
283+
request.addParameter(curParam.name.toString(), curParam.value.toString());
284+
continue;
288285
}
289-
else {
290-
request.addParameter(params[i].name, params[i].value);
286+
287+
let fileName = curParam.filename;
288+
if (fileName.startsWith("~/")) {
289+
fileName = fileName.replace("~/", fileSystemModule.knownFolders.currentApp().path + "/");
291290
}
291+
const destFileName = curParam.destFilename || fileName.substring(fileName.lastIndexOf('/') + 1, fileName.length);
292+
request.addFileToUpload(fileName, curParam.name, destFileName, curParam.mimeType);
292293
}
293294

294295
const utf8 = options.utf8;

0 commit comments

Comments
 (0)