Skip to content

fix(android-upload): Fix some params vars to be a string #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

romulowspp
Copy link
Contributor

@romulowspp romulowspp commented Oct 23, 2019

PR Checklist

What is the current behavior?

When the parameter payload has a type that isn't a string it throws one Java Exception about wrong type passed to method.

What is the new behavior?

Now you i convert all types in parameter value and name to string.

Fixes #249 .

Romulo Pires added 2 commits October 22, 2019 23:06
Convert param to string before send to Java method

Referenced in NativeScript#249
Removed missing lock files that i forget in before commit

Referenced in issue 249
@cla-bot
Copy link

cla-bot bot commented Oct 23, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Romulo Pires.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@romulowspp romulowspp closed this Oct 23, 2019
@romulowspp romulowspp reopened this Oct 23, 2019
@romulowspp
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 23, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @romulowspp.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Oct 23, 2019

The cla-bot has been summoned, and re-checked this pull request!

@romulowspp
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 23, 2019
@cla-bot
Copy link

cla-bot bot commented Oct 23, 2019

The cla-bot has been summoned, and re-checked this pull request!

@romulowspp romulowspp changed the title Fix llang 249 fix(android-upload): Fix some params vars to be a string Oct 23, 2019
@VladimirAmiorkov VladimirAmiorkov merged commit d770a2b into NativeScript:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only Android: Uncaught (in promise): Error: Cannot convert number to Ljava/lang/String; at index 1
2 participants