-
-
Notifications
You must be signed in to change notification settings - Fork 50
feat(android): add options to set notifications channel id, ringtone enabled and auto clear #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! :D
Hi @mukaschultze , Thank you for this PR. I reviewed and tested it and it works as expected. The only thing that I noticed is that if both Can you make this small update, after that I would be happy to merge and release a new version with this new feature. |
@VladimirAmiorkov notes added |
PR Checklist
What is the current behavior?
Currently, there is no way of changing some options of upload notifications that are available on android upload service.
What is the new behavior?
Three new fields were implemented to allow changing these settings,
androidRingToneEnabled
androidNotificationChannelID
andandroidAutoClearNotification
The changes made were based off on #71