Install devDependencies before prepare #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As our hooks (like typescript) are called before executing prepare method, we must be sure we have all devDependencies installed in order to be able to execute before-prepare hooks. This is mandatory for projects where typescript is enabled, but you do not have node_modules directory yet.
|
👍 |
|
Test PASSed. |
| let packageJsonContent = this.$fs.readJson(this.getPackageJsonFilePath()).wait(); | ||
| let devDependencies = _.keys(packageJsonContent.devDependencies); | ||
| if(devDependencies.length && (this.$options.force || _.difference(devDependencies, installedDependencies).length)) { | ||
| let command = `npm install ${devDependencies.join(" ")}`; |
There was a problem hiding this comment.
Can we use npm install --development?
There was a problem hiding this comment.
nope, I want only devDependencies to be installed, while npm i --development is installing everything including devDependencies.
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 13, 2015
Install devDependencies before prepare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our hooks (like typescript) are called before executing prepare method, we must be sure we have
all devDependencies installed in order to be able to execute before-prepare hooks.
This is mandatory for projects where typescript is enabled, but you do not have node_modules directory yet.
Steps to reproduce the bug:
tns create app1cd app1tns install typescriptrm -rf node_modulestns build androidYou'll see error: