Handle node check-v8-dependants.js throwing an exception
#2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st likely caused by previously traversed cyclic dependencies)
Plamen5kov
approved these changes
Mar 13, 2017
rosen-vladimirov
approved these changes
Mar 14, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a message if during before-prepare on android an exception is thrown (most likely caused by previously traversed cyclic dependencies) when spawning a node child process to check for plugins depending on the public V8 being exposed by the runtime.
It is important to note that the likely cause, for the process throwing an exception, can be viewed as a separate issue, as having cyclic production dependencies slows down the prepare step considerably.
More info: #2561 (comment)
Addresses: #2561