Always clean platforms/app when --bundle is passed #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2017 12:37
Whenever CLI is required as a library `$options` flags are not set. Hence `$options` should only be used where one knows CLI is truly run as a command-line interface - i.e. in commands.
rosen-vladimirov
approved these changes
Dec 13, 2017
sis0k0
approved these changes
Dec 13, 2017
|
Tested with: Tested commands in the following order: and it builds every and runs as expected with no excess files in |
rosen-vladimirov
pushed a commit
that referenced
this pull request
Dec 13, 2017
* Always clean platforms/app when `--bundle` is passed * Do not use $options in $nodeModulesBuilder Whenever CLI is required as a library `$options` flags are not set. Hence `$options` should only be used where one knows CLI is truly run as a command-line interface - i.e. in commands.
rosen-vladimirov
added a commit
that referenced
this pull request
Dec 13, 2017
* Always clean platforms/app when `--bundle` is passed * Do not use $options in $nodeModulesBuilder Whenever CLI is required as a library `$options` flags are not set. Hence `$options` should only be used where one knows CLI is truly run as a command-line interface - i.e. in commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
--bundleis passed because we may end up with duplicate symbols$optionsin$nodeModulesBuilderas CLI may berequired as a library where$optionsis not used at allPing @rosen-vladimirov @sis0k0