Skip to content

fix(analytics): undefined file is created on every command #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018
Merged

fix(analytics): undefined file is created on every command #4177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions lib/services/analytics/analytics-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,10 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
@cache()
private getAnalyticsBroker(): Promise<ChildProcess> {
return new Promise<ChildProcess>((resolve, reject) => {
const brokerProcessArgs = this.getBrokerProcessArgs();

const broker = this.$childProcess.spawn(process.execPath,
[
path.join(__dirname, "analytics-broker-process.js"),
this.$staticConfig.PATH_TO_BOOTSTRAP,
this.$options.analyticsLogFile // TODO: Check if passing path with space or quotes will work
],
brokerProcessArgs,
{
stdio: ["ignore", "ignore", "ignore", "ipc"],
detached: true
Expand Down Expand Up @@ -200,6 +198,19 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
});
}

private getBrokerProcessArgs(): string[] {
const brokerProcessArgs = [
path.join(__dirname, "analytics-broker-process.js"),
this.$staticConfig.PATH_TO_BOOTSTRAP,
];

if (this.$options.analyticsLogFile) {
brokerProcessArgs.push(this.$options.analyticsLogFile);
}

return brokerProcessArgs;
}

private async sendInfoForTracking(trackingInfo: ITrackingInformation, settingName: string): Promise<void> {
await this.initAnalyticsStatuses();

Expand Down