fix: fix device list-files, device get-file and device put-file commands
#4285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
reviewed
Jan 16, 2019
lib/project-data.ts
Outdated
| @@ -90,6 +90,14 @@ export class ProjectData implements IProjectData { | |||
| this.errorInvalidProject(projectDir); | |||
| } | |||
|
|
|||
| public initializeProjectDataSafe(projectDir?: string): void { | |||
There was a problem hiding this comment.
After a discussion we decided it is better to try/catch when needed, than adding a method.
DimitarTachev
approved these changes
Jan 17, 2019
|
run ci |
Fatme
force-pushed
the
fatme/fix-ios-device-commands
branch
from
42ddd02 to
1b01435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
device list-files,device get-fileanddevice put-filecommands fail with an error.What is the new behavior?
device list-files,device get-fileanddevice put-filecommands work correctly.Fixes/Implements/Closes #[Issue Number].