fix: enable debug-brk on real iOS devices #4296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and do not make an additional restart in the debug services.
PR Checklist
What is the current behavior?
Debug
Unit testing
tns test <platform> --debug-brk
is not working without--no-watch
tns test <platform> --debug-brk --no-watch
is throwing an exceptiontns test <platform> --debug-brk
is not working with multiple devicestns test <platform> --debug-brk
is not printing the debug URL--
tns dev-test <platform>
is throwing an exceptionCommon issues
CTRL + C
for 10 seconds after initial livesync.CTRL + C
handlers in the livesync service.What is the new behavior?
Debug
Unit testing
tns test <platform> --debug-brk
is working as expectedtns dev-test <platform>
is removedCommon issues
CTRL + C
just after the initial livesyncCTRL + C
handlers in the livesync service.Refactoring
getDebugSocket
method as we use the debug protocol for the LiveSync refresh method.IHasHasReconnected
flag of the debug services as they are not restarting the application anymore.prepareForLiveSync
method as it was making a redundantattachToDebuggerPortFoundEvent
call.debugStart
methods from the debug services as they were wrongly used in the unit testing.startLookingForDevices
call from the android debug service as we are ensuring this in all commands.$devicesService.initialize
and$devicesService.execute
calls from the debug services as we are ensuring the initialization in all commands are the debug services are always working with a single device.Related to: #3122, #3161