Skip to content

fix: don't build every time the application from sidekick when using cloud build #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 11, 2019

Currently the application is built every time from sidekick when opening the app and starting cloud build. This happens as we decided that there are changes in app_resources as prepareData.release is undefined but prepareInfo.release is false. This way the check prepareData.release !== this._prepareInfo.release passes and we set this._changesInfo.appResourcesChanged to true.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

…cloud build

Currently the application is built every time from sidekick when opening the app and starting cloud build. This happens as we decided that there are changes in app_resources as `prepareData.release` is undefined but `prepareInfo.release` is false. This way the check `prepareData.release !== this._prepareInfo.release` passes and we set `this._changesInfo.appResourcesChanged` to `true`.
@cla-bot cla-bot bot added the cla: yes label Jul 11, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jul 11, 2019

test cli-smoke

@Fatme Fatme merged commit d291adc into release Jul 11, 2019
@Fatme Fatme deleted the fatme/fix-cloud-build-sidekick branch July 11, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants