Do not delete values dirs #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| @@ -185,9 +185,9 @@ class AndroidProjectService implements IPlatformProjectService { | |||
| public prepareAppResources(appResourcesDirectoryPath: string): IFuture<void> { | |||
| return (() => { | |||
| let resourcesDirPath = path.join(appResourcesDirectoryPath, this.platformData.normalizedPlatformName); | |||
| let resourcesDirs = this.$fs.readDirectory(resourcesDirPath).wait(); | |||
| let resourcesDirs = this.$fs.readDirectory(resourcesDirPath).wait().filter(resDir => !resDir.match(/^values/)); | |||
There was a problem hiding this comment.
You can move the regexp outside the lambda, but not a merge stopper
|
👍 |
During project preparation, we should not delete values directories as they contain specific information, which is important for android builds (strings.xml file for example).
rosen-vladimirov
force-pushed
the
vladimirov/fix-values-dir
branch
from
60961c2 to
bcba5fb
Compare
|
✅ |
rosen-vladimirov
added a commit
that referenced
this pull request
Jul 13, 2015
Do not delete values dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During project preparation, we should not delete values directories as they contain specific information, which is important for android builds (strings.xml file for example).
NOTE: This fix is mandatory for integration of {N} inside AppBuilder