Skip to content

Update node-sass dependency #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Conversation

evanfuture
Copy link
Contributor

There is an issue with watchers in the latest version of node-sass. This fixes us to to the last version that worked. Fixes issue #47

There is an issue with watchers in the latest version of node-sass.  This fixes us to to the last version that worked.
@vakrilov
Copy link
Contributor

Thanks @evanfuture!

@vakrilov vakrilov merged commit d410f58 into NativeScript:master Nov 10, 2017
@datanotion
Copy link

This was driving me crazy - I must have been running an older version, as it seems to work now.

As a side note, this issue was fixed 2 days ago in node-sass: https://github.com/sass/node-sass/pull/2151/files

Question though - nativescript-dev-sass still seems to be transferring the .sass file to the device as well - is that what is causing the app to restart even on style changes?

image

@evanfuture
Copy link
Contributor Author

I'll keep an eye on that fix, and make another PR here to bump the version once it's out of pre-release (4.7.0) and I test it out of course.

I don't know about the sass files, but yes, that would trigger a restart. I thought I read somewhere that it would be nice to not have them transfer, but no one had the time to take that up. Not sure!

@evanfuture
Copy link
Contributor Author

Ok, checked it out and made a PR: #51 Works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants