Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Different behaviour for getCurrentLocation #78

Closed
surdu opened this issue Oct 16, 2017 · 3 comments
Closed

Different behaviour for getCurrentLocation #78

surdu opened this issue Oct 16, 2017 · 3 comments

Comments

@surdu
Copy link
Contributor

surdu commented Oct 16, 2017

When you call getCurrentLocation from a cold start, usually the location is very old (several minutes). This in turn will cause getCurrentLocation to fail every time if you specify maximumAge to something like 10 seconds.

What I propose is to change the behaviour of getCurrentLocation like this:

Attempt to retrieve the location as it is today. Check if the timestamp of location <= maximumAge. If the check fails, retry location fetching until timeout or timestamp is ok.

@DimitarTachev
Copy link
Contributor

Hi @surdu,

Thanks for the feedback!

This sounds like a very nice improvement. I've labeled it with 'help wanted' and 'good first issue' as someone from the community could open a pull request before we get to it.

@AnthonySmith01
Copy link

Same issue here, basically breaks the whole plugin.

Has anyone had a try at implementing the above logic?

@DimitarTachev
Copy link
Contributor

Fixed and released

@ghost ghost removed the feature label Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants