This repository was archived by the owner on Nov 8, 2023. It is now read-only.
fix iOS returning old location when maximumAge is set #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, get a timestamp of when the app is started and prevent locations older than that from being returned. After a recent (after app started) location is aquired, clear the app start timestamp and continue checking the maximumAge to maintain location accuracy. Remove "location too old" check when timeout is set - proper logic is just to keep waiting for a recent location until timeout expires.
ghost
assigned 
DimitarTachev
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, get a timestamp of when the app is started and prevent locations older than that from being returned.
After a recent (after app started) location is aquired, clear the app start timestamp and continue checking the maximumAge to maintain location accuracy.
Remove "location too old" check when timeout is set - proper logic is just to keep waiting for a recent location until timeout expires.
Addresses #78 and #79