Allowing access to location in Airplane mode with GPS on #116
Conversation
ghost
added
the
src/geolocation.android.ts
Outdated
| @@ -4,8 +4,11 @@ import { setTimeout, clearTimeout } from "timer"; | |||
| import { LocationBase, defaultGetLocationTimeout, fastestTimeUpdate, minTimeUpdate } from "./geolocation.common"; | |||
| import { Options, successCallbackType, errorCallbackType } from "./location-monitor"; | |||
| import * as permissions from "nativescript-permissions"; | |||
| import System = android.provider.Settings.System; | |||
There was a problem hiding this comment.
This will break the Webpack + Snapshot build. We should not access the native APIs (like android... or com...) in the root scope. Such shorthands should be avoided.
src/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "nativescript-geolocation", | |||
| "version": "4.2.3", | |||
| "version": "4.3.0", | |||
There was a problem hiding this comment.
As far as I see this is a bug fix, not a feature. It could be just 4.2.4.
|
@DimitarTachev Thanks for taking time to review, have pushed the requested changes. Hope its good to merge now. |
src/geolocation.android.ts
Outdated
| @@ -6,6 +6,7 @@ import { Options, successCallbackType, errorCallbackType } from "./location-moni | |||
| import * as permissions from "nativescript-permissions"; | |||
|
|
|||
| declare var com: any; | |||
| const LocationSettingsStatusCodes = com.google.android.gms.location.LocationSettingsStatusCodes; | |||
There was a problem hiding this comment.
I believe the Snapshot build will also fail here + you should also rebase your branch onto master :)
There was a problem hiding this comment.
I have pushed the changes, thanks for letting me know about these issues.
But just wondering still my app works fine with webpack and snapshot using same code. Is there a documentation that explains do / don'ts with webpack / snapshot?
There was a problem hiding this comment.
It seems that we should improve the docs. Meanwhile, you could take a look at this blog post: https://www.nativescript.org/blog/improving-app-startup-time-on-android-with-webpack-v8-heap-snapshot
There was a problem hiding this comment.
Thank you @DimitarTachev but that blog also looks like very old, I'm not finding any guidelines on what we suppose to not do / follow with snapshot builds. Am I missing something?
Hope to see some guidelines in appropriate docs soon - https://docs.nativescript.org/best-practices/bundling-with-webpack#v8-heap-snapshot
Thanks a lot for taking time to response.
|
@DimitarTachev Can you please take a look and merge this, I could really use the updated version. |
|
Thank you @DimitarTachev Could you please push a build to NPM as well? |
|
@manojdcoder We will try to publish it later today or tomorrow. |
#108: After lot of research at my end, I think this is the only way to handle GPS in airplane mode.