Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Replaced the Android implementation with the recommended one. #72

Merged
merged 13 commits into from
Oct 11, 2017
Merged

Replaced the Android implementation with the recommended one. #72

merged 13 commits into from
Oct 11, 2017

Conversation

DimitarTachev
Copy link
Contributor

Trying to fix #42 and #62

Replaced the Android Location Manager approach with the Google Play Location Service one (used by Google Maps) as there are a lot of known issues with the Location Manager and it's not the recommended approach for getting a location on Android.

Breaking changes:

  • the isEnabled method returns 'Promise' instead of 'boolean'
  • the updateDistance option is not available for android anymore, use updateTime instead. (A hint from Google - update interval of 5000 milliseconds (5 seconds), causes the location provider to return location updates that are accurate to within a few feet".

DimitarTachev and others added 10 commits September 28, 2017 22:51
@ghost ghost assigned DimitarTachev Oct 6, 2017
@ghost ghost added the new PR label Oct 6, 2017
This was referenced Oct 6, 2017
Closed
Closed
@DimitarTachev DimitarTachev merged commit 71fe85f into master Oct 11, 2017
@ghost ghost removed the new PR label Oct 11, 2017
@DimitarTachev DimitarTachev deleted the tachev/location-manager-to-google-play-services branch October 11, 2017 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zbranzov zbranzov zbranzov approved these changes

Assignees

@DimitarTachev DimitarTachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getCurrentLocation gets timeout on Android API17
2 participants
@DimitarTachev @zbranzov