-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat: basic update for @nativescript/[email protected] #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NathanWalker let's start supporting Angular 9. Would be great to check my changes in detail. |
@d-koppenhagen excellent start here! Thank you - we'll collaborate here 👍 |
to be alinged with the Angular CLI Breaking Change intorduced in 9.0.0. See: https://github.com/angular/angular-cli/releases/tag/v9.0.0 BREAKING CHANGE: use `style` CLI option instead of `styleext` option from now
@NathanWalker there are still two tests failing: It seems that there is some logic removing one Module in case the other is used.
I couldn't dig deeper into it until now. |
Oh and will |
@d-koppenhagen Yes on webpack. That will become |
@NathanWalker okay, the breaking stuff was my faulf: I also adjusted the Angular CLI migartion script from previous version which should stay the same as before as they will be applied step by step. Still open: Migration script from current version to new version |
PR Checklist
What is the current behavior?
Running the current schematics with an Angular 9 project needs some manual changes after it:
https://github.com/NativeScript/nativescript-angular/wiki/Updating-and-developing-for-@nativescript-angular-v9-with-Ivy-or-without
What is the new behavior?
The changes will add the manual steps to the schematics so that they will work immediately with angular9.
Fixes/Implements/Closes #275.
BREAKING CHANGES:
Angular 9 is required.