Skip to content

fix(angular): update typescript to version 4 for ng new #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020
Merged

fix(angular): update typescript to version 4 for ng new #303

merged 1 commit into from
Dec 1, 2020

Conversation

macjohnny
Copy link
Contributor

@macjohnny macjohnny commented Oct 22, 2020

PR Checklist

What is the current behavior?

After creating a new project, when creating a component with

ng new -c=@nativescript/schematics project-name --shared
ng g component bla

an error occurs:

Cannot read property 'kind' of undefined

What is the new behavior?

No error occurs

Fixes/Implements/Closes #302

@cla-bot
Copy link

cla-bot bot commented Oct 22, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @macjohnny.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@macjohnny
Copy link
Contributor Author

@cla-bot check

1 similar comment
@macjohnny
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 22, 2020
@cla-bot
Copy link

cla-bot bot commented Oct 22, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker
Copy link
Contributor

Thank you @macjohnny

@NathanWalker NathanWalker merged commit 605b24a into NativeScript:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'kind' of undefined using TypeScript 3.9.0
2 participants