Skip to content

fix: check for snapshot skipped message only in 'rc' #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2019
Merged

fix: check for snapshot skipped message only in 'rc' #386

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d91506
check for snapshot skipped message only in rc
endarova Oct 3, 2019
970b160
Merge branch 'master' into endarova/win_snapshot_tests
endarova Oct 3, 2019
47d5ae8
fix lint
endarova Oct 3, 2019
7d74db1
remove snapshot skipped check from tests
endarova Oct 3, 2019
a4597dc
remove unused imports
endarova Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion data/sync/hello_world_js.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ def run_hello_world_js_ts(app_name, platform, device, bundle=True, hmr=True, ugl
result = Tns.run(app_name=app_name, platform=platform, emulator=True, wait=False, bundle=bundle, hmr=hmr,
release=release, uglify=uglify, aot=aot, snapshot=snapshot, sync_all_files=sync_all_files,
just_launch=just_launch)
TnsAssert.snapshot_skipped(snapshot, result, release)

if os.environ.get('nativescript') == 'rc':
TnsAssert.snapshot_skipped(snapshot, result, release)

strings = TnsLogs.run_messages(app_name=app_name, platform=platform, run_type=RunType.UNKNOWN, bundle=bundle,
hmr=hmr, instrumented=instrumented, device=device, release=release,
Expand Down
3 changes: 2 additions & 1 deletion data/sync/hello_world_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ def run_hello_world_ng(app_name, platform, device, bundle=True, uglify=False, ao
# Execute tns run command
result = Tns.run(app_name=app_name, platform=platform, emulator=emulator, bundle=bundle, aot=aot,
uglify=uglify, hmr=hmr, release=release, snapshot=snapshot, device=device_id)
TnsAssert.snapshot_skipped(snapshot, result, release)
if os.environ.get('nativescript') == 'rc':
TnsAssert.snapshot_skipped(snapshot, result, release)

# Check logs
strings = TnsLogs.run_messages(app_name=app_name, platform=platform, run_type=RunType.UNKNOWN, bundle=bundle,
Expand Down
3 changes: 2 additions & 1 deletion data/sync/master_details_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ def run_master_detail_ng(app_name, platform, device, bundle=True, hmr=True, ugli
release=False, snapshot=False):
result = Tns.run(app_name=app_name, platform=platform, emulator=True, wait=False, bundle=bundle,
hmr=hmr, aot=aot, uglify=uglify, snapshot=snapshot, release=release)
TnsAssert.snapshot_skipped(snapshot, result, release)
if os.environ.get('nativescript') == 'rc':
TnsAssert.snapshot_skipped(snapshot, result, release)

# Verify it looks properly
device.wait_for_text(text=Changes.MasterDetailNG.TS.old_text, timeout=450, retry_delay=5)
Expand Down