feat: Migrate secure-storage plugin #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugins into migrate-secure-storage-plugin
|
wow fantastic @grigala thank you! |
NathanWalker
approved these changes
Jun 16, 2023
|
This will ease maintenance on this in future, published 3.0.1 for good measure as well when this merged. |
No worries, yes we are aware of maintenance related bottlenecks and since we are actively using NativeScript and some of the plugins in production - we decided to contribute back as much as we can. That is whenever we have time :) This particular MR has been worked out as part of Hackergarten meetup group. We constantly try to organize these meetups to contribute back to Open-Souirce projects. More info: https://www.hackergarten.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from: https://github.com/EddyVerbruggen/nativescript-secure-storage