Skip to content

Repair install_environment_variable def #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Repair install_environment_variable def #20

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2018 •
edited by ghost
Loading

install_environment_variable has three problems:

  1. It breaks appending with ENV values that contain one or more spaces
  2. It appends variables without first checking if it's already defined in the existing target file
  3. It breaks scripts because ENV values are not quoted

Repair install_environment_variable def
5897c54 
`install_environment_variable` has three problems:

1. It breaks appending with ENV values that contain one or more spaces
2. It appends variables without first checking if it's already defined in the existing target file
3. It breaks scripts because ENV values are not quoted
@ghost
Copy link
Author

ghost commented Dec 2, 2018

Ping @NickIliev this is a showstopper

@etabakov
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Feb 25, 2019
@cla-bot
Copy link

cla-bot bot commented Feb 25, 2019

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rosen-vladimirov rosen-vladimirov

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etabakov @rosen-vladimirov