fix(taro-vite-runner): 修复 vite h5 dev & build 路径未转 posix 导致的异常#16124
Merged
ZEJIA-LIU merged 2 commits intoNervJS:mainfrom Jul 25, 2024
Merged
fix(taro-vite-runner): 修复 vite h5 dev & build 路径未转 posix 导致的异常#16124ZEJIA-LIU merged 2 commits intoNervJS:mainfrom
ZEJIA-LIU merged 2 commits intoNervJS:mainfrom
Conversation
ZEJIA-LIU
approved these changes
Jul 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16124 +/- ##
==========================================
- Coverage 61.05% 61.03% -0.03%
==========================================
Files 445 445
Lines 22939 22939
Branches 5022 4966 -56
==========================================
- Hits 14005 14000 -5
- Misses 7957 8127 +170
+ Partials 977 812 -165
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 27, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

这个 PR 做了什么? (简要描述所做更改)
windows 环境下,vite h5 dev 和 build 时候,resolveId 根据 configPath 判断是否 app.config.ts,但 resolve 后的路径为 posix,configPath 未转换,导致逻辑失效。
这里将 configPath 路径进行转换,同时对 dev 模式下生成 code 路径进行转换,避免 dev 解析失效
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: