fix(weapp): 修复微信 Map 组件在 Android 环境下且小程序基础库 v3.4.10+ 出现的属性配置异常#16603
Merged
fix(weapp): 修复微信 Map 组件在 Android 环境下且小程序基础库 v3.4.10+ 出现的属性配置异常#16603
Conversation
1. 优化 isNumber 判断逻辑; 2. 修复微信 Map 组件 setting 属性的默认设置值问题;
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16603 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 466 466
Lines 27109 27115 +6
Branches 5959 5956 -3
=======================================
+ Hits 15862 15866 +4
- Misses 9903 9925 +22
+ Partials 1344 1324 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
咨询一下,目前这个问题修复了之后,Taro历史版本是否是自己做兼容? |
Contributor
Author
|
是的,旧版本需要手动添加 |
了解,看上面这个问题被合并到4.0.7分支下,后续是不是Taro 4.0.7 及以后版本不需要做这类的容错 |
This was referenced Sep 28, 2024
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
setting属性的默认设置值问题;这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: