fix(Form):Form 表单在 Web 下缺乏 type=“submit” 属性 by felix9ia · Pull Request #17892 · NervJS/taro

felix9ia · 2025-06-26T08:09:56Z

这个 PR 做了什么？ (简要描述所做更改)

这个 PR 是什么类型？ (至少选择一个)

错误修复 (Bugfix) issue: fix # [Bug]: Form 表单在 Web 下缺乏 type=“submit” 属性，导致无法触发 submit 方法 #17855
新功能 (Feature)
代码重构 (Refactor)
TypeScript 类型定义修改 (Types)
文档修改 (Docs)
代码风格更新 (Code style update)
构建优化 (Chore)
其他，请描述 (Other, please describe):

这个 PR 涉及以下平台：

Summary by CodeRabbit

优化
- 改进了按钮和输入元素的表单类型属性处理，增强了提交和重置按钮的兼容性。

coderabbitai · 2025-06-26T08:10:28Z

## Walkthrough

移除了 `specialElements` 中 `button` 元素的完整映射条目，改为在 `modifyHydrateData` 钩子中针对 `input` 和 `button` 元素的 `type` 属性为 `"submit"` 或 `"reset"` 时，动态添加 `formType` 属性。

## Changes

| 文件/分组                                      | 变更摘要                                                         |
|------------------------------------------------|------------------------------------------------------------------|
| packages/taro-plugin-html/src/constant.ts       | 移除 `specialElements` 中 `button` 条目及其 `mapName` 和 `mapAttr` 实现。 |
| packages/taro-plugin-html/src/runtime.ts        | 在 `modifyHydrateData` 钩子中新增逻辑，为 `input` 和 `button` 元素的 `type` 为 `"submit"` 或 `"reset"` 时，添加 `formType` 属性。 |

## Poem

> 小兔轻跳代码间，  
> 按钮映射去旧颜。  
> 类型提交添新意，  
> 表单行为更自然。  
> HTML 细节巧安排，  
> 功能完善乐开怀！  
> 🐇💻✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8def6 and b64b8c1.

📒 Files selected for processing (2)

packages/taro-plugin-html/src/constant.ts (0 hunks)
packages/taro-plugin-html/src/runtime.ts (1 hunks)

💤 Files with no reviewable changes (1)

packages/taro-plugin-html/src/constant.ts

✅ Files skipped from review due to trivial changes (1)

packages/taro-plugin-html/src/runtime.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
GitHub Check: Build Rust WASM / stable - wasm32-wasi

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yoyo837 · 2025-06-26T08:12:47Z

+    mapAttr (key, value, props) {
      if (key === 'type' && (value === 'submit' || value === 'reset')) {
-        key = 'formType'
+        props.formType = value


这个感觉很副作用的感觉

@yoyo837 确实看起来很 hack，但是能生效🤦‍♂️
我没有找到比这个位置更好的挂载点来同时支持这两个属性.....很苦涩。
如果有更好的实现方式，请指出，我来改。

codecov · 2025-06-26T08:29:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.99%. Comparing base (7642ca8) to head (b64b8c1).
⚠️ Report is 98 commits behind head on main.

❌ Your project check has failed because the head coverage (54.99%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17892   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         417      417           
  Lines       21696    21696           
  Branches     5358     5360    +2     
=======================================
  Hits        11931    11931           
+ Misses       8090     8083    -7     
- Partials     1675     1682    +7

Flag	Coverage Δ
taro-cli	`72.56% <ø> (ø)`
taro-runtime	`59.87% <ø> (ø)`
taro-web	`53.19% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

felix9ia · 2025-07-19T08:13:59Z

+    data.formType = data.type
+  }
+  // button[type=submit|reset] 时，额外添加 formType 属性
+  if (nodeName === 'button' && (data.type === 'submit' || data.type === 'reset')) {


@yoyo837 ，看看在这个位置修改，合适吗？

@yoyo837 有时间review 一下看新的 commit 是否合适

yoyo837 reviewed Jun 26, 2025

View reviewed changes

felix9ia added 2 commits July 19, 2025 15:51

fix(Form):Form 表单在 Web 下缺乏 type=“submit” 属性

6c68baf

在 hooks 中增加 formType 属性

b64b8c1

felix9ia force-pushed the main branch from 1f8def6 to b64b8c1 Compare July 19, 2025 08:11

felix9ia commented Jul 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Form):Form 表单在 Web 下缺乏 type=“submit” 属性#17892

fix(Form):Form 表单在 Web 下缺乏 type=“submit” 属性#17892
felix9ia wants to merge 2 commits intoNervJS:mainfrom
felix9ia:main

felix9ia commented Jun 26, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

yoyo837 Jun 26, 2025

Uh oh!

felix9ia Jun 27, 2025

Uh oh!

codecov Bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

felix9ia Jul 19, 2025

Uh oh!

felix9ia Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

felix9ia commented Jun 26, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

yoyo837 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

felix9ia Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

felix9ia Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

felix9ia Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

felix9ia commented Jun 26, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Jun 26, 2025 •

edited

Loading