fix: components exports#17916
Conversation
Walkthrough本次变更为 Changes
Sequence Diagram(s)sequenceDiagram
participant Consumer
participant ComponentsIndex
participant ComponentDirIndex
participant ComponentModule
Consumer->>ComponentsIndex: import { X } from 'components'
ComponentsIndex->>ComponentDirIndex: export * from './X'
ComponentDirIndex->>ComponentModule: export * from './X'
ComponentModule-->>Consumer: 组件实现
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 6
♻️ Duplicate comments (22)
packages/taro-components/src/components/cover-view/index.ts (1)
1-2: 同上:请确认 default 导出是否遗漏packages/taro-components/src/components/map/index.ts (1)
1-2: 同上:请确认 default 导出是否遗漏packages/taro-components/src/components/progress/index.ts (1)
1-2: 同上:请确认 default 导出是否遗漏packages/taro-components/src/components/button/index.ts (1)
1-2: 同上:请确认 default 导出是否遗漏packages/taro-components/src/components/open-container/index.ts (1)
1-1: 同上一文件:检查默认导出是否被遗漏
若./open-container包含default导出,需要追加显式转发。packages/taro-components/src/components/camera/index.ts (1)
1-1: 同 switch/index.ts 的导出问题
请核实是否需转发default。packages/taro-components/src/components/image/index.ts (1)
1-1: 检查默认导出转发
确保不会因default导出缺失而破坏现有 API。packages/taro-components/src/components/lifestyle/index.ts (1)
1-1: 重复提醒:确认 default 导出
如有export default Lifestyle,请同步转发。packages/taro-components/src/components/label/index.ts (1)
1-1: 与 Canvas 相同的默认导出问题
同样仅透出命名导出,请参考canvas/index.ts的评论,确认是否需补充默认导出。packages/taro-components/src/components/web-view/index.ts (1)
1-1: 与 Canvas 相同的默认导出问题
同样仅透出命名导出,请参考canvas/index.ts的评论,确认是否需补充默认导出。packages/taro-components/src/components/script/index.ts (1)
1-1: 与 Canvas 相同的默认导出问题
同样仅透出命名导出,请参考canvas/index.ts的评论,确认是否需补充默认导出。packages/taro-components/src/components/lottie/index.ts (1)
1-1: 同上,export *未包含 default。若./lottie有默认导出请同步补充。packages/taro-components/src/components/custom-wrapper/index.ts (1)
1-1: 同上,需确认并补充默认导出。packages/taro-components/src/components/login/index.ts (1)
1-1: 同上,需确认并补充默认导出。packages/taro-components/src/components/view/index.ts (1)
1-1: 同上,需确认并补充默认导出。packages/taro-components/src/components/contact-button/index.ts (1)
1-1: 同样遗漏default导出原因与
share-element相同。请参考以下修复:-export * from './contact-button' +export { default } from './contact-button' +export * from './contact-button'packages/taro-components/src/components/keyboard-accessory/index.ts (1)
1-1: 桶文件未透传默认导出与前述文件一致,需补充
default:-export * from './keyboard-accessory' +export { default } from './keyboard-accessory' +export * from './keyboard-accessory'packages/taro-components/src/components/navigator/index.ts (1)
1-1: 缺失默认导出透传保持一致性并避免破坏性变更:
-export * from './navigator' +export { default } from './navigator' +export * from './navigator'packages/taro-components/src/components/slider/index.ts (1)
1-1: 同 rich-text:default未被转出同样需要补充
export { default } from './slider',否则默认导入失效。packages/taro-components/src/components/horizontal-drag-gesture-handler/index.ts (1)
1-1: 同上:谨防漏转 default
./script若导出默认组件,也需要显式 re-export。packages/taro-components/src/components/textarea/index.ts (1)
1-1: 同上:补充 default re-export请参见 rich-text 的评论。
packages/taro-components/src/components/grid-view/index.ts (1)
1-1: 同上:default 导出未转出确保
grid-view默认导出不被遗漏。
🧹 Nitpick comments (20)
packages/taro-components/src/components/animation-video/index.ts (1)
1-1: 确认 default 导出是否遗漏
export *不会转 re-exportdefault。若./animation-video模块提供了默认导出(常见于 React/Taro 组件),当前桶文件会丢失该导出,导致import AnimationVideo from '.../animation-video'失效。如需同时导出默认值,请追加显式声明:
export * from './animation-video' +export { default } from './animation-video'packages/taro-components/src/components/ar-camera/index.ts (1)
1-1: 建议保留文件末尾换行符当前文件缺少终止换行符,容易在后续提交中被
git diff反复标红。统一在所有index.ts末尾加一行空行即可。-export * from './ar-camera' +export * from './ar-camera' +packages/taro-components/src/components/page-container/index.ts (1)
1-2: 同样缺少终止换行符为保持代码风格一致,请在文件末尾添加换行。
-export * from './page-container' +export * from './page-container' +packages/taro-components/src/components/cover-image/index.ts (1)
1-2: 补充 EOF 换行保持一致性,避免无意义 diff。
-export * from './cover-image' +export * from './cover-image' +packages/taro-components/src/components/audio/index.ts (1)
1-1: 补充 EOF 换行建议所有桶文件统一添加结尾换行。
-export * from './audio' +export * from './audio' +packages/taro-components/src/components/input/index.ts (1)
1-2: 补充 EOF 换行保持仓库代码风格一致。
-export * from './input' +export * from './input' +packages/taro-components/src/components/switch/index.ts (1)
1-1: 确认是否应同时转发默认导出
export *仅转发具名导出,不会将default一并导出。若./switch内部存在export default Switch,则现有写法会导致import Switch from '@tarojs/components'在升级后抛出运行时或编译期错误。请确认组件实现的导出方式,并在需要时追加:
export * from './switch' +export { default } from './switch'packages/taro-components/src/components/video/index.ts (1)
1-3: 显式命名导出可降低潜在命名冲突风险连续使用
export *会把video-control、video-danmu、video三个模块里的所有符号全部抛出,一旦这些文件里存在同名导出(或未来演进中出现同名符号),就会触发「重复导出」编译错误,CI 才会暴露问题,排查成本较高。
如果只需要暴露少量公共组件 / 类型,建议改为显式命名导出,或在 barrel 中做统一别名处理。示例 diff:-export * from './video-control' -export * from './video-danmu' -export * from './video' +export { VideoControl } from './video-control' +export { VideoDanmu } from './video-danmu' +export { Video } from './video'packages/taro-components/src/components/tabbar/index.ts (1)
1-2: 考虑导出顺序及命名冲突
tabbar-item与tabbar可能同时导出重名符号(如均导出default或泛用类型名),使用export *方式时需确认内部命名唯一。可采用显式导出或设置别名降低风险,方式同视频组件建议。packages/taro-components/src/components/vertical-drag-gesture-handler/index.ts (1)
1-1: 脚本命名不直观,建议显式导出标识
export * from './script'隐去了组件真正的名称,后续在全局搜索或 tree-shaking 统计时不直观。可考虑:-export * from './script' +export { default as VerticalDragGestureHandler } from './script' +export * from './script'这样即兼容默认导出,也提升可读性。
packages/taro-components/src/components/follow-swan/index.ts (1)
1-1: 通配符导出可能影响 tree-shaking,可考虑显式导出
export *虽然快捷,但在组件库场景下容易导致未使用成员被打包进最终产物;如果./follow-swan中还包含内部工具函数或类型,建议显式列出真正需要暴露的组件/类型,提升 tree-shaking 效果并避免潜在命名冲突。packages/taro-components/src/components/pan-gesture-handler/index.ts (1)
1-2:script文件命名含义不直观,建议显式说明相比大多数组件直接 re-export 同名文件,这里指向
./script,容易让使用者或新贡献者疑惑。可以考虑:-export * from './script' +// 统一命名保持可读性 +export * from './pan-gesture-handler'或者在
script.ts里增加注释说明其职责。packages/taro-components/src/components/block/index.ts (1)
1-1: 桶文件 OK,但可加注释提高可维护性建议在顶端加一句简短注释说明此文件仅用于汇出,避免后续误加逻辑代码。
packages/taro-components/src/components/root-portal/index.ts (1)
1-1: 通配导出可能暴露内部实现,建议显式导出公共 API
export *会把./root-portal中的所有导出(包含可能仅供内部使用的类型 / 常量)全部暴露出去,给后续的 breaking change 带来负担。若组件只需暴露默认导出或少量命名导出,建议改为显式列举,以减少公共接口面。-export * from './root-portal' +export { default as RootPortal } from './root-portal' +// 若还有其他需要暴露的符号,请在此显式列出packages/taro-components/src/index.ts (1)
1-1: 路径写法轻微多余,建议回退为目录别名
./components/index与./components指向同一文件,但后者更符合 Node/TS 的解析习惯,也避免日后文件改名造成遗漏。若无特殊需求,可简化为:-export * from './components/index' +export * from './components'packages/taro-components/src/components/scale-gesture-handler/index.ts (1)
1-1: 路径命名与统一性检查大多数组件的 barrel 文件采用
export * from './<component>',此处却指向./script。若只是文件名不同无妨,但如果后续有人按惯例去找scale-gesture-handler.ts可能产生困惑。建议:
- 确认
script.ts是否为最终实现文件;- 若无特殊原因,考虑改成与目录同名的实现文件,以保持一致性。
packages/taro-components/src/components/channel-live/index.ts (1)
1-1: 同样考虑默认导出转发如
./channel-live内含default,请参照下述方式一并转发,以避免破坏现有 API:export * from './channel-live' +export { default } from './channel-live'packages/taro-components/src/components/inline-payment-panel/index.ts (1)
1-1: 使用export *可能影响 Tree-shaking通配导出方便但会把所有符号都暴露出去,某些打包器(尤其是开启 side-effects 剔除时)可能无法精确摇树。若组件较大或包含副作用文件,建议改成显式命名导出,或者在
package.json使用"sideEffects": false进行声明。packages/taro-components/src/components/channel-video/index.ts (1)
1-1: 与其他 barrel 文件一致,但仍建议显式导出同样的
export *写法在几十个组件里重复出现,可考虑脚本化自动生成,并在后期转为显式导出以获得更好的类型提示与摇树效果。packages/taro-components/src/components/index.ts (1)
1-88: 集中 Barrel 文件建议自动生成一次性手写近百行导出容易遗漏、排序出错,后续维护成本高。可考虑:
- 使用脚本(如
ts-node scripts/gen-components-index.ts)扫描目录自动生成;- 在 CI 中校验 index 文件与目录实际组件是否一致,防止漏掉新增组件。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (89)
packages/taro-components/src/components/ad-custom/index.ts(1 hunks)packages/taro-components/src/components/ad/index.ts(1 hunks)packages/taro-components/src/components/animation-video/index.ts(1 hunks)packages/taro-components/src/components/animation-view/index.ts(1 hunks)packages/taro-components/src/components/ar-camera/index.ts(1 hunks)packages/taro-components/src/components/audio/index.ts(1 hunks)packages/taro-components/src/components/aweme-data/index.ts(1 hunks)packages/taro-components/src/components/block/index.ts(1 hunks)packages/taro-components/src/components/button/index.ts(1 hunks)packages/taro-components/src/components/camera/index.ts(1 hunks)packages/taro-components/src/components/canvas/index.ts(1 hunks)packages/taro-components/src/components/channel-live/index.ts(1 hunks)packages/taro-components/src/components/channel-video/index.ts(1 hunks)packages/taro-components/src/components/checkbox/index.ts(1 hunks)packages/taro-components/src/components/comment/index.ts(1 hunks)packages/taro-components/src/components/contact-button/index.ts(1 hunks)packages/taro-components/src/components/cover-image/index.ts(1 hunks)packages/taro-components/src/components/cover-view/index.ts(1 hunks)packages/taro-components/src/components/custom-wrapper/index.ts(1 hunks)packages/taro-components/src/components/double-tap-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/draggable-sheet/index.ts(1 hunks)packages/taro-components/src/components/editor/index.ts(1 hunks)packages/taro-components/src/components/follow-swan/index.ts(1 hunks)packages/taro-components/src/components/force-press-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/form/index.ts(1 hunks)packages/taro-components/src/components/functional-page-navigator/index.ts(1 hunks)packages/taro-components/src/components/grid-builder/index.ts(1 hunks)packages/taro-components/src/components/grid-view/index.ts(1 hunks)packages/taro-components/src/components/horizontal-drag-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/icon/index.ts(1 hunks)packages/taro-components/src/components/image/index.ts(1 hunks)packages/taro-components/src/components/index.ts(1 hunks)packages/taro-components/src/components/inline-payment-panel/index.ts(1 hunks)packages/taro-components/src/components/input/index.ts(1 hunks)packages/taro-components/src/components/keyboard-accessory/index.ts(1 hunks)packages/taro-components/src/components/label/index.ts(1 hunks)packages/taro-components/src/components/lifestyle/index.ts(1 hunks)packages/taro-components/src/components/like/index.ts(1 hunks)packages/taro-components/src/components/list-builder/index.ts(1 hunks)packages/taro-components/src/components/list-view/index.ts(1 hunks)packages/taro-components/src/components/live-player/index.ts(1 hunks)packages/taro-components/src/components/live-pusher/index.ts(1 hunks)packages/taro-components/src/components/login/index.ts(1 hunks)packages/taro-components/src/components/long-press-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/lottie/index.ts(1 hunks)packages/taro-components/src/components/map/index.ts(1 hunks)packages/taro-components/src/components/match-media/index.ts(1 hunks)packages/taro-components/src/components/movable-area/index.ts(1 hunks)packages/taro-components/src/components/navigation-bar/index.ts(1 hunks)packages/taro-components/src/components/navigator/index.ts(1 hunks)packages/taro-components/src/components/nested-scroll-body/index.ts(1 hunks)packages/taro-components/src/components/nested-scroll-header/index.ts(1 hunks)packages/taro-components/src/components/official-account/index.ts(1 hunks)packages/taro-components/src/components/open-container/index.ts(1 hunks)packages/taro-components/src/components/open-data/index.ts(1 hunks)packages/taro-components/src/components/page-container/index.ts(1 hunks)packages/taro-components/src/components/page-meta/index.ts(1 hunks)packages/taro-components/src/components/pan-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/picker-view/index.ts(1 hunks)packages/taro-components/src/components/picker/index.ts(1 hunks)packages/taro-components/src/components/progress/index.ts(1 hunks)packages/taro-components/src/components/pull-to-refresh/index.ts(1 hunks)packages/taro-components/src/components/radio/index.ts(1 hunks)packages/taro-components/src/components/rich-text/index.ts(1 hunks)packages/taro-components/src/components/root-portal/index.ts(1 hunks)packages/taro-components/src/components/rtc-room/index.ts(1 hunks)packages/taro-components/src/components/scale-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/script/index.ts(1 hunks)packages/taro-components/src/components/scroll-view/index.ts(1 hunks)packages/taro-components/src/components/share-element/index.ts(1 hunks)packages/taro-components/src/components/slider/index.ts(1 hunks)packages/taro-components/src/components/slot/index.ts(1 hunks)packages/taro-components/src/components/snapshot/index.ts(1 hunks)packages/taro-components/src/components/span/index.ts(1 hunks)packages/taro-components/src/components/sticky-header/index.ts(1 hunks)packages/taro-components/src/components/sticky-section/index.ts(1 hunks)packages/taro-components/src/components/swiper/index.ts(1 hunks)packages/taro-components/src/components/switch/index.ts(1 hunks)packages/taro-components/src/components/tabbar/index.ts(1 hunks)packages/taro-components/src/components/tabs/index.ts(1 hunks)packages/taro-components/src/components/tap-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/text/index.ts(1 hunks)packages/taro-components/src/components/textarea/index.ts(1 hunks)packages/taro-components/src/components/vertical-drag-gesture-handler/index.ts(1 hunks)packages/taro-components/src/components/video/index.ts(1 hunks)packages/taro-components/src/components/view/index.ts(1 hunks)packages/taro-components/src/components/voip-room/index.ts(1 hunks)packages/taro-components/src/components/web-view/index.ts(1 hunks)packages/taro-components/src/index.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (75)
📓 Common learnings
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/animation-view/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/cover-view/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/ar-camera/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/canvas/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/ad/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/animation-video/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/custom-wrapper/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/ad-custom/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/aweme-data/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/functional-page-navigator/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/force-press-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/double-tap-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/audio/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/grid-builder/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/editor/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/camera/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/channel-live/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/button/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/channel-video/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/rtc-room/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/like/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/follow-swan/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/view/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/script/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/map/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/horizontal-drag-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/block/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/lottie/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/progress/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/tap-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/radio/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/switch/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/list-builder/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/pan-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/root-portal/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/open-data/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/form/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/long-press-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/navigation-bar/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/span/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/snapshot/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/icon/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/match-media/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/text/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/image/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/input/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/rich-text/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/tabbar/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/textarea/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/sticky-header/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/nested-scroll-body/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/navigator/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/vertical-drag-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/share-element/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/scale-gesture-handler/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/page-meta/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/slot/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/movable-area/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/web-view/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/login/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/voip-room/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/page-container/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/video/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/sticky-section/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/live-pusher/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/nested-scroll-header/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/lifestyle/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/slider/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/scroll-view/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/live-player/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/label/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
packages/taro-components/src/components/official-account/index.ts (1)
Learnt from: ianzone
PR: NervJS/taro#17746
File: packages/taro-runtime/tsdown.config.ts:10-16
Timestamp: 2025-05-25T18:02:31.387Z
Learning: 在 taro-runtime 包的 tsdown 配置中,必须禁用 treeshake 来保留 dom-external/index.js 文件。
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
- GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
🔇 Additional comments (42)
packages/taro-components/src/components/text/index.ts (1)
1-1: 请确认是否需要同时透出 default 导出
export * from './text'不会转 re-export 默认导出。如果./text.tsx内部存在export default Text,下游代码使用import Text from '@tarojs/components/dist/text'将会失效。建议同步导出默认值以避免破坏兼容性。示例修正:
export * from './text' +// 若存在默认导出,追加以下代码保持兼容性 +export { default as Text } from './text'packages/taro-components/src/components/aweme-data/index.ts (1)
1-1: 同样注意 default 导出的遗漏风险
export *不含 default,若aweme-data有默认导出将造成破坏性变更。请确认并视情况追加:export * from './aweme-data' +export { default as AwemeData } from './aweme-data'packages/taro-components/src/components/movable-area/index.ts (1)
1-2: 可能出现重名冲突,需验证编译是否通过
movable-area与movable-view这两个模块若导出同名标识(如MovableAreaProps等),在此桶文件里会触发 “重复导出” 编译错误。请跑一次tsc --noEmit确认。若冲突,可采用命名空间或显式别名:-export * from './movable-area' -export * from './movable-view' +export * as MovableArea from './movable-area' +export * as MovableView from './movable-view'packages/taro-components/src/components/form/index.ts (1)
1-1: default 导出兼容性检查
如前面组件,确认form组件是否有默认导出;若有需显式 re-export:export * from './form' +export { default as Form } from './form'packages/taro-components/src/components/like/index.ts (1)
1-1: 留意 default 导出缺失问题
保持与其它组件一致,避免因未导出默认值而破坏现有调用方。若需要:export * from './like' +export { default as Like } from './like'packages/taro-components/src/components/pull-to-refresh/index.ts (1)
1-1: LGTM,保持与其他 barrel 文件的一致性文件结构简洁,符合本 PR 统一出口的改造目标,无其它问题。
packages/taro-components/src/components/nested-scroll-body/index.ts (1)
1-1: 保持 export 语句风格一致与同目录其他 barrel 文件保持一致,代码无问题。
packages/taro-components/src/components/sticky-header/index.ts (1)
1-1: LGTM实现与整体导出策略一致,没有发现问题。
packages/taro-components/src/components/tap-gesture-handler/index.ts (1)
1-1: 无需为 tap-gesture-handler 添加default转发经在
packages/taro-components/src/components/tap-gesture-handler目录下搜索export default,未发现任何默认导出,故不需要额外添加
export { default } from './script'。Likely an incorrect or invalid review comment.
packages/taro-components/src/components/picker-view/index.ts (1)
1-2: 确认导出正确:无默认导出且无命名冲突经验证,
packages/taro-components/src/components/picker-view下仅有index.ts、picker-view.tsx(导出PickerView类)和picker-view-column.tsx(导出PickerViewColumn类),均未使用export default,且两者的命名导出互不重复,export * from不会产生冲突。无需额外修改。packages/taro-components/src/components/span/index.ts (1)
1-1: 导出写法符合统一化策略 👍采用 barrel 文件
export * from './span'与本次 PR 的整体导出重构保持一致,暂无可见问题。packages/taro-components/src/components/voip-room/index.ts (1)
1-1: 保持一致性 OK同样的 barrel 导出实现,与其他组件保持风格一致,可直接合并。
packages/taro-components/src/components/swiper/index.ts (1)
1-2: 留意命名冲突风险
swiper-item与swiper可能包含同名导出(例如default、SwiperProps等)。使用export *聚合时若存在同名符号会导致构建错误。请确认两个文件中的导出成员无重名;如有冲突,需改用显式重命名:
export { default as SwiperItem } from './swiper-item' export * from './swiper-item' export { default as Swiper } from './swiper' export * from './swiper'packages/taro-components/src/components/double-tap-gesture-handler/index.ts (1)
1-1: 保持一致性 OK与其它 gesture-handler 组件统一导出,无功能性问题。
packages/taro-components/src/components/canvas/index.ts (1)
1-1: 无需重导出默认成员经排查
packages/taro-components/src/components/canvas下的canvas.tsx和index.ts中均未发现任何export default声明,export * from './canvas'已覆盖所有命名导出,因此无需额外添加export { default }。packages/taro-components/src/components/rtc-room/index.ts (1)
1-2: 忽略不必要的默认导出重导出建议
经过验证,rtc-room.tsx与rtc-room-item.tsx均仅使用命名导出(export class RtcRoom/export class RtcRoomItem),且导出名称互不冲突。index.ts中的export * from './rtc-room-item' export * from './rtc-room'已正确将所有命名导出暴露,无需额外的
export { default as … }或重构。Likely an incorrect or invalid review comment.
packages/taro-components/src/components/picker/index.ts (1)
1-2: 请确认聚合导出在顶层components/index.ts中已同步
picker-group与picker均通过通配符导出聚合,若顶层packages/taro-components/src/components/index.ts未同时 re-export,本文件将无法被外部直接访问到。请核对并确保已加入,否则建议补充导出或在此处添加注释说明暂不对外暴露的原因。packages/taro-components/src/components/comment/index.ts (1)
1-2: 名称空间冲突风险提醒
comment-detail与comment-list可能导出同名标识符(如均导出Props),通过export *聚合时会产生冲突并导致编译错误。请检视两个模块的导出名称,必要时使用显式导出或as重命名。packages/taro-components/src/components/functional-page-navigator/index.ts (1)
1-1: LGTM文件仅作 barrel 导出,符合现有组件库结构,无其他问题。
packages/taro-components/src/components/match-media/index.ts (1)
1-1: LGTM一致性 barrel 文件,改动正确。
packages/taro-components/src/components/radio/index.ts (1)
1-2: 确认避免命名冲突
radio-group与radio很可能都导出诸如default、RadioProps等相同标识符。export *会在编译阶段直接报冲突,从而阻断构建。请在本地跑一次tsc --noEmit或 CI 里确保这两个模块的导出集合不存在重名。packages/taro-components/src/components/ad/index.ts (1)
1-1: 导出桶文件实现符合预期仅做简单 re-export,没有潜在副作用,保持与其他组件目录一致的结构,👍。
packages/taro-components/src/components/snapshot/index.ts (1)
1-1: 保持一致性 👍实现与其它组件导出方式保持一致,无问题。
packages/taro-components/src/components/grid-builder/index.ts (1)
1-1: 请手动确认 grid-builder.tsx 是否定义了默认导出在自动化搜索中未能找到
export default语句,请在以下文件中手动检查并确认:
- packages/taro-components/src/components/grid-builder/grid-builder.tsx
若组件文件已包含默认导出,则应在
index.ts中补充:export * from './grid-builder' +export { default } from './grid-builder'否则可保留现有写法或在组件文件内先添加默认导出后再统一 re-export。
packages/taro-components/src/components/editor/index.ts (1)
1-1: 保持与其他组件导出方式一致
同一 PR 中多数组件均使用export *,保持一致性无问题;注意未来若需要隐藏实现细节,可考虑改为显式导出。packages/taro-components/src/components/open-data/index.ts (1)
1-1: 确认open-data模块没有副作用导出
通配导出会包含模块内的所有副作用代码;请确认open-data.ts中未在顶层执行逻辑,避免 barrel 文件被引入即触发副作用。若有副作用应在原文件中注释说明。packages/taro-components/src/components/list-builder/index.ts (1)
1-1: LGTM
简单 barrel file,符合目录统一规范。packages/taro-components/src/components/share-element/index.ts (1)
1-1: 无需添加默认导出传递经确认,
packages/taro-components/src/components/share-element/share-element.tsx仅包含命名导出export class ShareElement,并无export default。因此当前的桶文件export * from './share-element'已完整地再导出了所有命名导出,且并不存在需要“透传”的默认导出。无需修改此处代码。
Likely an incorrect or invalid review comment.
packages/taro-components/src/components/page-meta/index.ts (1)
1-1: 统一出口实现良好新增的 barrel 文件符合组件统一导出策略,无功能性问题。请同步确认
packages/taro-components的exports/typesVersions配置已覆盖此路径,避免外部解析失败。packages/taro-components/src/components/ad-custom/index.ts (1)
1-1: 简单透传导出 OK与其他组件保持一致,便于简化引用路径。无额外意见。
packages/taro-components/src/components/live-pusher/index.ts (1)
1-1: barrel 文件增加成功实现与目录命名保持一致,易于 IDE 补全,暂无隐患。
packages/taro-components/src/components/checkbox/index.ts (1)
1-2: 多个子组件聚合导出需关注命名冲突
checkbox-group与checkbox本身不会重名,但若未来再添加复选框相关子组件,需确保不会与现有命名产生混淆。packages/taro-components/src/components/list-view/index.ts (1)
1-1: 统一出口符合改造目标代码简单直观,保持一致性 👍
packages/taro-components/src/components/rich-text/index.ts (1)
1-1: 无需添加默认导出:模块未定义默认导出
经在 packages/taro-components/src/components/rich-text 目录下全量搜索,未发现任何export default声明,说明该模块仅使用命名导出。export * from './rich-text'已涵盖所有可用导出,无需额外添加export { default }。Likely an incorrect or invalid review comment.
packages/taro-components/src/components/live-player/index.ts (1)
1-1: 确认是否需要转发默认导出
export *不会包含default,如果./live-player内部导出了默认组件,外部将拿不到它。为避免破坏现有用法,建议补充对默认导出的显式转发:export * from './live-player' +export { default } from './live-player'请检查原组件实现并视情况添加。
packages/taro-components/src/components/slot/index.ts (1)
1-2: 潜在导出名称冲突同时对两个模块做
export *,若两侧存在同名导出,会在编译阶段报冲突。请确认native-slot与slot中的命名导出无重叠,或改用显式命名转发以避免冲突。packages/taro-components/src/components/scroll-view/index.ts (1)
1-1: LGTM – 仅提醒文档同步实现简单且符合其他组件写法。别忘了同步更新外部文档示例中的导入路径,避免用户仍从旧路径引用。
packages/taro-components/src/components/sticky-section/index.ts (1)
1-1: 无需转发默认导出
经核查,packages/taro-components/src/components/sticky-section/sticky-section.tsx文件中仅导出命名类StickySection,并无export default,因此在index.ts中添加-export * from './sticky-section' +export * from './sticky-section' +export { default } from './sticky-section'并不会生效,原有
export *已足够,无需额外转发默认导出。Likely an incorrect or invalid review comment.
packages/taro-components/src/components/icon/index.ts (1)
1-1: 无需导出默认组件在 packages/taro-components/src/components/icon/icon.tsx 中使用了命名导出 (
export class Icon),并未导出default,因此无需在index.ts中添加-export * from './icon' +export * from './icon' // 无需添加:export { default } from './icon'packages/taro-components/src/components/draggable-sheet/index.ts (1)
1-1: 模块内无默认导出,无需添加默认转发
经在packages/taro-components/src/components/draggable-sheet目录下使用rg 'export default'验证,未检索到任何默认导出声明。直接在index.ts中添加export * from './draggable-sheet' +export { default } from './draggable-sheet'会导致编译错误。请忽略此建议;如确实需要提供默认导出,可先在
draggable-sheet.tsx内添加对应的export default。Likely an incorrect or invalid review comment.
packages/taro-components/src/components/nested-scroll-header/index.ts (1)
1-1: 保持组件目录内的导出单一职责目前仅封装 re-export,没有问题。若后续
nested-scroll-header目录里再新增 util 函数或类型,务必避免在同一 barrel 中混入实现代码,保持纯导出文件属性。packages/taro-components/src/components/index.ts (1)
58-58: 确认为何临时注释掉picker导出
// export * from './picker';被注释,可能导致外部调用无法正确引入 picker 相关组件。请确认:
- 是否由于编译或类型冲突临时关闭?
- 若功能尚未准备好,是否应添加 TODO 说明并在文档中标明不可用?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17916 +/- ##
=======================================
Coverage 54.95% 54.95%
=======================================
Files 419 419
Lines 21750 21750
Branches 5350 5385 +35
=======================================
Hits 11953 11953
- Misses 8122 8153 +31
+ Partials 1675 1644 -31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@yoyo837 合一下? |
这个 PR 做了什么? (简要描述所做更改)



之前的构建
现在的构建



这个 PR 是什么类型? (至少选择一个)
Summary by CodeRabbit
新功能
杂项