Skip to content

fix(taro-platform-h5): 修复windows开发环境Taro对象上等方法不可用 #18151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Adamlyu-hub wants to merge 1 commit into from
Closed

fix(taro-platform-h5): 修复windows开发环境Taro对象上等方法不可用 #18151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/taro-platform-h5/src/program.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,17 @@ export default class H5 extends TaroPlatformWeb {
const viteCompilerContext = await getViteH5CompilerContext(this)
if (viteCompilerContext) {
const exts = Array.from(new Set(viteCompilerContext.frameworkExts.concat(SCRIPT_EXT)))
if (id.startsWith(viteCompilerContext.sourceDir) && exts.some((ext) => id.includes(ext))) {

let cleanId = id

if (cleanId.startsWith('\u0000')) {
cleanId = cleanId.slice(1)
}

cleanId = cleanId.split('?')[0].replace(/\\/g, '/') // 👈 替换斜杠方向

const normalizedSourceDir = viteCompilerContext.sourceDir.replace(/\\/g, '/') // 👈 替换斜杠方向
if (cleanId.startsWith(normalizedSourceDir) && exts.some((ext) => id.includes(ext))) {
Comment on lines +236 to +237
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

避免路径前缀误匹配：建议加“目录边界”判定

当前使用 startsWith 可能将 /src 与 /src2 误判为命中。建议在归一化后为 sourceDir 补尾随斜杠，或计算相对路径/使用边界判断，降低误伤范围。

可考虑最小变更如下：

-              const normalizedSourceDir = viteCompilerContext.sourceDir.replace(/\\/g, '/') // 👈 替换斜杠方向
-              if (cleanId.startsWith(normalizedSourceDir) && exts.some((ext) => id.includes(ext))) {
+              let normalizedSourceDir = viteCompilerContext.sourceDir.replace(/\\/g, '/') // 👈 替换斜杠方向
+              normalizedSourceDir = normalizedSourceDir.replace(/\/+$/, '') + '/'
+              const inSourceDir = cleanId.startsWith(normalizedSourceDir)
+              if (inSourceDir && exts.some((ext) => id.includes(ext))) {
🤖 Prompt for AI Agents 
In packages/taro-platform-h5/src/program.ts around lines 236 to 237, the current
use of startsWith to check if cleanId begins with normalizedSourceDir can cause
false positives when paths like <sourceDir>/src2 are mistaken for
<sourceDir>/src. To fix this, ensure normalizedSourceDir ends with a trailing
slash after normalization, then check if cleanId starts with this adjusted path
to enforce directory boundary matching and avoid incorrect matches.

// @TODO 后续考虑使用 SWC 插件的方式实现
const result = await transformAsync(code, {
filename: id,
Expand Down
Loading