Skip to content

chore: node22 #18578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianzone wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore: node22 #18578

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
58ce338
chore: node24
ianzone Nov 6, 2025
600e302
chore: remove mac13
ianzone Nov 11, 2025
df8c016
Merge branch 'main' into node24
ianzone Nov 12, 2025
5ee1482
test: timeout
ianzone Nov 12, 2025
92dde7f
Merge branch 'main' into node24
ianzone Nov 23, 2025
0dac44b
test: puppeteer
ianzone Nov 23, 2025
08efd71
Merge branch 'main' into node24
ianzone Dec 8, 2025
0a97428
Merge branch 'main' into node24
ianzone Dec 9, 2025
b104fd7
chore: node 22
ianzone Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/build-rust-binding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,24 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x]
node-version: [22]
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

PR 目标与代码不匹配：缺少 Node.js 24 版本。

PR 标题为"chore: node24"，PR 目标明确提到"为 Node.js 22、Node.js 24 和 macOS ARM 架构添加测试"，但矩阵中仅包含 [22]，缺少 Node.js 24。根据最新信息，Node.js 24 已于 2025 年 10 月 31 日正式进入长期支持（LTS）并将继续接收维护和安全更新至 2028 年 4 月。

请确认是否应在矩阵中添加 Node.js 24。如果是有意为之，请更新 PR 描述以反映实际的测试范围。

建议的修复：

-        node-version: [22]
+        node-version: [22, 24]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
node-version: [22]
node-version: [22, 24]
🤖 Prompt for AI Agents 
.github/workflows/build-rust-binding.yml around line 17: the GitHub Actions
node-version matrix currently lists only [22] while the PR title/description
claims tests for Node.js 22 and 24; update the matrix to include Node.js 24
(e.g., node-version: [22, 24]) so CI runs for both versions, or if 24 is
intentionally omitted, adjust the PR title/description to accurately reflect the
actual tested versions.

settings:
- host: macos-13
target: x86_64-apple-darwin
build: |
pnpm build:binding:release
strip -x crates/native_binding/*.node
- host: windows-latest
build: pnpm build:binding:release
target: x86_64-pc-windows-msvc
- host: ubuntu-22.04
- host: ubuntu-latest
target: x86_64-unknown-linux-gnu
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
build: |-
set -e &&
npm install -g corepack@0.31.0 &&
pnpm build:binding:release --target x86_64-unknown-linux-gnu &&
strip crates/native_binding/*.node
- host: ubuntu-22.04
- host: ubuntu-latest
target: x86_64-unknown-linux-musl
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
build: set -e && pnpm build:binding:release && strip crates/native_binding/*.node
- host: macos-13
- host: macos-latest
target: aarch64-apple-darwin
build: |
pnpm build:binding:release --target aarch64-apple-darwin
Expand Down
20 changes: 8 additions & 12 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,16 @@ jobs:
- build-rust-wasm
strategy:
matrix:
node-version: [18.x, 20.x]
host: [macos-13, windows-latest, ubuntu-latest]
node-version: [22, 24]
host: [macos-latest, windows-latest, ubuntu-latest]
exclude:
- node-version: 18.x
host: macos-13
- node-version: 18.x
host: windows-latest
- node-version: 20.x
host: macos-13
- node-version: 20.x
- node-version: 22
host: macos-latest
- node-version: 22
host: windows-latest
Comment thread
ianzone marked this conversation as resolved.
Outdated
include:
- host: macos-13
target: x86_64-apple-darwin
- host: macos-latest
target: aarch64-apple-darwin
- host: windows-latest
target: x86_64-pc-windows-msvc
- host: ubuntu-latest
Expand All @@ -74,7 +70,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: pnpm -r install --frozen-lockfile
run: pnpm install --frozen-lockfile
Comment thread
ianzone marked this conversation as resolved.
- name: Lint
run: pnpm lint
- name: Download artifact bindings-${{ matrix.target }}
Expand Down
5 changes: 3 additions & 2 deletions packages/taro-components/scripts/stencil/stencil.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ export const config: Config = {
{ components: ['taro-video-core', 'taro-video-control', 'taro-video-danmu'] }
],
/**
* Note: Taro内部有很多地方都直接引用了dist/components，最终的编译产物中有很多super()，导致低版安装白屏
* 为彻底解决此包导致的白屏问题，故暂不在包构建是转为es5，而是将此包加入到项目的babel编译中
* Note: Taro 内部有很多地方都直接引用了 dist/components，最终的编译产物中有很多 super()，导致低版安装白屏
* 为彻底解决此包导致的白屏问题，故暂不在包构建是转为 es5，而是将此包加入到项目的 babel 编译中
*/
// buildEs5: 'prod',
/**
Expand All @@ -99,6 +99,7 @@ export const config: Config = {
* 实际并不支持 clone 模式，暂不考虑修复
*/
testing: {
browserArgs: ['--no-sandbox', '--disable-setuid-sandbox'],
globals: {
'ts-jest': {
diagnostics: false,
Expand Down
Loading