Skip to content

Revert/main #18685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Single-Dancer merged 4 commits into from
Jan 8, 2026
Merged

Revert/main #18685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecdbd83
Revert "chore: stencil update (#18649)"
Dec 19, 2025
05736cb
Revert "test(babel-plugin-transform-solid-jsx): vitest (#18607)"
Dec 19, 2025
c481ac1
fix: 目前 macos 无法正常执行测试，暂时跳过，等待后续优化
Jan 8, 2026
4e27eab
chore(ci): 替换过期的macos镜像
Single-Dancer Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
- name: GITHUB CONTEXT
env:
GITHUB_CONTEXT: ${{ toJson(github) }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-rust-binding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
node-version: [18.x]
settings:
- host: macos-13
- host: macos-latest
target: x86_64-apple-darwin
build: |
pnpm build:binding:release
Expand All @@ -36,7 +36,7 @@ jobs:
target: x86_64-unknown-linux-musl
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
build: set -e && pnpm build:binding:release && strip crates/native_binding/*.node
- host: macos-13
- host: macos-latest
target: aarch64-apple-darwin
build: |
pnpm build:binding:release --target aarch64-apple-darwin
Expand All @@ -45,7 +45,7 @@ jobs:
runs-on: ${{ matrix.settings.host }}
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

确认 v5 继续获得维护和安全更新

v5 版本继续获得安全更新和主要破坏性变更的修复。v5.0.0 在 2024 年 8 月发布，v5.0.1 在 2024 年 11 月发布，表明该版本仍在主动维护中。

但需要注意：v6 存在与非 GitHub 平台自托管运行器的兼容性问题，因为 v6 使用硬编码的 GitHub Actions 路径，导致 Git 认证失败并造成工作流挂起和超时。对于自托管运行器，建议使用 v5，因为它采用通用 HTTP 授权标头方式，适用于所有平台。

如果项目使用 GitHub 托管的运行器，两个版本都可以工作。如果使用自托管或第三方运行器（Forgejo、Gitea 等），v5 实际上是更好的选择。建议确认此次降级的具体原因。

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-rust-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
- name: Setup Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-update-lockfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
with:
ref: ${{ github.head_ref }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
template: [bug_report.yml]

steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5

- name: 解析模板
uses: stefanbuck/github-issue-parser@v3
Expand Down
23 changes: 15 additions & 8 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@ jobs:
strategy:
matrix:
node-version: [18.x, 20.x]
host: [macos-13, windows-latest, ubuntu-latest]
host: [macos-latest, windows-latest, ubuntu-latest]
exclude:
- node-version: 18.x
host: macos-13
host: macos-latest
- node-version: 18.x
host: windows-latest
- node-version: 20.x
host: macos-13
host: macos-latest
- node-version: 20.x
host: windows-latest
include:
- host: macos-13
- host: macos-latest
target: x86_64-apple-darwin
- host: windows-latest
target: x86_64-pc-windows-msvc
Expand All @@ -63,7 +63,7 @@ jobs:
runs-on: ${{ matrix.host }}
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
Expand All @@ -74,7 +74,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
run: pnpm -r install --frozen-lockfile
- name: Lint
run: pnpm lint
- name: Download artifact bindings-${{ matrix.target }}
Expand Down Expand Up @@ -110,7 +110,14 @@ jobs:
env:
NODE_OPTIONS: --max_old_space_size=4096
- name: test
run: pnpm run pretest:ci && pnpm test
#TODO: 需要优化测试流程，目前 macos 无法正常执行测试，暂时跳过，等待后续优化
shell: bash
run: |
if [ "${{ matrix.host }}" = "macos-latest" ]; then
pnpm -r --aggregate-output --filter=./packages/* --filter=./tests --filter=!@tarojs/components test:ci
else
pnpm test
fi
Comment on lines 112 to +120
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

条件测试执行降低了 macOS 平台的测试覆盖率。

新增的条件测试流程在 macos-latest 上跳过了部分包（如 @tarojs/components）的测试，仅在其他平台执行完整测试。这存在以下风险：

  1. 平台特定 bug 可能被遗漏：被排除的包在 macOS 上的问题无法被及时发现
  2. 测试覆盖率下降：macOS 平台的可靠性保障减弱
  3. 技术债务：TODO 注释表明这是临时方案，但可能长期存在

建议：

  • 记录 macOS 测试失败的具体原因和影响范围
  • 创建跟踪 issue 来优先修复 macOS 测试问题
  • 考虑添加 CI 提醒，定期检查此临时方案的状态

您是否需要我帮助创建一个跟踪 issue 来记录 macOS 测试问题和后续优化计划？

🤖 Prompt for AI Agents 
In @.github/workflows/nodejs.yml around lines 112 - 120, The test job currently
conditionally skips some package tests when matrix.host equals "macos-latest" by
running a filtered pnpm command (see the "test" step and the conditional
checking matrix.host), which reduces macOS coverage; update the workflow to stop
excluding @tarojs/components on macOS (remove the special-case filtered pnpm
call) or make the macOS branch run the same pnpm -r --aggregate-output command
as other hosts, and add an accompanying TODO->ISSUE: create a tracking issue
documenting the macOS test failures (include reproduction steps, failing
packages, and impact) and add a CI reminder (e.g., a comment or an automated
periodic job) so this temporary workaround is triaged and resolved promptly.

# 以下 coverage 流程通过 artifact 拆分文件作为单独 job 上传时间损耗过长，因此在在 node test 后直接继续执行
- name: Upload [taro-cli] coverage to Codecov
uses: codecov/codecov-action@v5
Expand Down Expand Up @@ -151,7 +158,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
- name: Setup Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
steps:
# Setup
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5

# Log meta
- name: GITHUB CONTEXT
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
steps:
# Setup
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v5
with:
ref: ${{ github.ref_name }}
- name: Setup pnpm
Expand Down Expand Up @@ -276,7 +276,7 @@ jobs:
run: pnpm build

- name: Checkout Harmony Project
uses: actions/checkout@v6
uses: actions/checkout@v5
with:
repository: NervJS/taro-harmony-project
path: packages/taro-platform-harmony-cpp/harmony_project
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sync-components-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v6
uses: actions/checkout@v5

- name: Checkout taro-docs
uses: actions/checkout@v6
uses: actions/checkout@v5
with:
repository: NervJS/taro-docs
fetch-depth: 1
Expand Down
9 changes: 3 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
"lint:style": "stylelint ./packages/**/*.{css,scss}",
"format": "prettier --write --cache .",
"format:check": "prettier --check --cache .",
"pretest:ci": "node ./scripts/download.mjs",
"test": "pnpm --if-present -r --filter=./packages/* --filter=./tests test:ci",
"test": "pnpm --if-present -r --aggregate-output --filter=./packages/* --filter=./tests test:ci",
"test:binding": "pnpm --filter @tarojs/binding run test",
"updateSnapshot": "pnpm --if-present -r --aggregate-output --filter=./tests --filter=./packages/* updateSnapshot",
"version": "run-s version:*",
Expand Down Expand Up @@ -110,7 +109,7 @@
"@types/webpack-dev-server": "^3.11.3",
"@typescript-eslint/eslint-plugin": "^7.8.0",
"@typescript-eslint/parser": "^7.8.0",
"@vitest/coverage-istanbul": "^4.0.14",
"@vitest/coverage-istanbul": "^3.2.4",
"babel-jest": "^29.7.0",
"babel-plugin-syntax-jsx": "6.18.0",
"babel-preset-power-assert": "3.0.0",
Expand Down Expand Up @@ -152,7 +151,6 @@
"power-assert": "^1.6.1",
"prettier": "^2.7.1",
"prop-types": "^15.7.2",
"puppeteer": "^20.9.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"rimraf": "^5.0.0",
Expand All @@ -166,8 +164,7 @@
"ts-node": "^10.9.1",
"tslib": "^2.6.2",
"typescript": "~5.4.5",
"vite": "^7.2.6",
"vitest": "^4.0.14"
"vitest": "^3.2.4"
},
"pnpm": {
"packageExtensions": {
Expand Down
1 change: 0 additions & 1 deletion packages/babel-plugin-transform-react-jsx-to-rn-stylesheet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"clean": "rimraf ./dist",
"test": "vitest run",
"test:ci": "vitest run --coverage",
"updateSnapshot": "vitest run --update",
"dev": "tsc -w",
"build": "tsc"
},
Expand Down
Loading