fix(ascf): 增加OpenEmbeddedAtomicservice组件#19114
Merged
Single-Dancer merged 1 commit intoNervJS:mainfrom Apr 22, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (7)
Walkthrough新增 OpenEmbeddedAtomicservice 组件及其 Stencil 实现、框架类型声明（React/Solid/Vue3）、barrel 重新导出、组件 README、以及 ASCF 平台的组件注册与 reflectApis 中的 Changes
Sequence Diagram(s)(已省略 —— 变更为添加新组件与类型，未引入复杂的跨组件控制流图示需求。) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/taro-components/types/OpenEmbeddedAtomicservice.d.ts (1)
25-25: 考虑使用Record<string, unknown>替代object以获得更好的类型提示。当前
wantParam?: object的宽泛类型与 Navigator 的extraData?: object和 FunctionalPageNavigator 的args?: object保持一致。虽然当前实现符合已有代码风格，但若无兼容性约束，改为Record<string, unknown>能提供更好的类型推导和开发体验。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/taro-components/types/OpenEmbeddedAtomicservice.d.ts` at line 25, The property wantParam?: object in the OpenEmbeddedAtomicservice type is too broad—replace its type with wantParam?: Record<string, unknown> to improve IDE/type inference; update the declaration in OpenEmbeddedAtomicservice.d.ts (the wantParam symbol) accordingly, run TypeScript checks to ensure compatibility with Navigator.extraData/FunctionalPageNavigator.args usages, and adjust any call sites or tests that relied on the looser object type if compilation errors arise.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/taro-components/types/OpenEmbeddedAtomicservice.d.ts`:
- Line 25: The property wantParam?: object in the OpenEmbeddedAtomicservice type
is too broad—replace its type with wantParam?: Record<string, unknown> to
improve IDE/type inference; update the declaration in
OpenEmbeddedAtomicservice.d.ts (the wantParam symbol) accordingly, run
TypeScript checks to ensure compatibility with
Navigator.extraData/FunctionalPageNavigator.args usages, and adjust any call
sites or tests that relied on the looser object type if compilation errors
arise.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 604c179a-37dd-4ce1-bf5d-b21bb5097c9c
📒 Files selected for processing (11)
packages/taro-components/src/components/index.tspackages/taro-components/src/components/open-embedded-atomicservice/index.tspackages/taro-components/src/components/open-embedded-atomicservice/open-embedded-atomicservice.tsxpackages/taro-components/src/components/open-embedded-atomicservice/readme.mdpackages/taro-components/types/OpenEmbeddedAtomicservice.d.tspackages/taro-components/types/index.d.tspackages/taro-components/types/index.solid.d.tspackages/taro-components/types/index.vue3.d.tspackages/taro-platform-ascf/src/components-react.tspackages/taro-platform-ascf/src/components.tspackages/taro-platform-ascf/src/reflect-apis.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19114 +/- ##
=======================================
Coverage 56.07% 56.07%
=======================================
Files 447 447
Lines 23454 23454
Branches 5816 5785 -31
=======================================
Hits 13151 13151
- Misses 8447 8453 +6
+ Partials 1856 1850 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Apr 18, 2026
Single-Dancer
approved these changes
Apr 21, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么？ (简要描述所做更改)
针对ASCF元服务，增加OpenEmbeddedAtomicservice组件
这个 PR 是什么类型？ (至少选择一个)
这个 PR 涉及以下平台：
Summary by CodeRabbit